Drop @here in fjord threads (#267)

@Heres are not generally useful in threads due to inclusion rules.
thesis · Jun 19, 2023 · d5290ef · d5290ef
2 parents 72a3562 + 16b6e6d
commit d5290ef
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -17,7 +17,9 @@ jobs:
     - name: Output environment
       run: |
         echo '${{ github.ref }}'
-        echo '${{ toJSON(github.event) }}'
+        echo <<-EOF
+          ${{ toJSON(github.event) }}
+        EOF
     outputs:
       # Run builds for all non-comment triggers.
       should-build: >-

diff --git a/discord-scripts/discord-webhook.ts b/discord-scripts/discord-webhook.ts
@@ -36,15 +36,12 @@ export default async function webhookDiscord(
     )
 
     if (existingThread) {
-      await existingThread.send("@here")
       await existingThread.send(message)
     } else {
       const newThread = await channel.threads.create({
         name: title,
-        autoArchiveDuration: 60,
         reason: message,
       })
-      await newThread.send("@here")
       if (tagUser !== "0") {
         await Promise.all(
           memberIds.map((id) => newThread.members.add(id.trim())),

diff --git a/discord-scripts/fjord.ts b/discord-scripts/fjord.ts
@@ -194,7 +194,6 @@ export default async function manageFjord(discordClient: Client, robot: Robot) {
                   name: `Stale issues: ${repositoryOwner} ${repositoryName}`,
                   autoArchiveDuration: 60,
                 })
-                await thread.send("@here")
                 await thread.send(response.data)
               }
             })
@@ -249,7 +248,6 @@ export default async function manageFjord(discordClient: Client, robot: Robot) {
                   name: `Issues: ${repositoryOwner} ${repositoryName}`,
                   autoArchiveDuration: 60,
                 })
-                await thread.send("@here")
                 await thread.send(response.data)
               }
             })