-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog: Add 1.0 changes #1851
Conversation
Pull Request Test Coverage Report for Build 1863174413Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like almost everything is present. Leaving some minor comments.
Should we add bug fixes?
- Metadata API: Role keyids is not ordered #1478 /role keyids still not ordered #1752
- ngclient: should clean temp file if write fails #1575
- Not sure if this was present before 0.20.0: ngclient: throws securesystemslib errors #1761
They should be in the list, just with the PR number and not the issue number (I can see an argument for using issue numbers: it's just potentially a lot more work since Out of your list all others have PRs in the list except 1754 and 1478: the latter was "fixed" last summer already but the former does seem to have the wrong issue number in the changelog. Thanks! I fixed that and rebased to include the latest PRs 1850, 1848, 1855, 1809. |
It looks good this way as well (i.e. without specific "Bug fixes" section). I think that after having all latest required PRs merged (including the not yet opened for #1852) this should be good to go. |
rebased, added a commit that documents the new PRs in that rebase (this can be squashed, just trying to make this easier to review) |
Looks good to me. |
Signed-off-by: Jussi Kukkonen <[email protected]>
Signed-off-by: Jussi Kukkonen <[email protected]>
Signed-off-by: Jussi Kukkonen <[email protected]>
rebased again, added a commit that documents the new merges in that rebase (this can be squashed, just trying to make this easier to review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at all commits after release 0.20.0
and it seems that all changes are here.
LGTM!
Superseded by #1873 |
Leaving as draft for now: