Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: Add 1.0 changes #1851

Closed
wants to merge 3 commits into from
Closed

Conversation

jku
Copy link
Member

@jku jku commented Feb 9, 2022

Leaving as draft for now:

  • I believe I've listed all relevant changes so far (some trivial PRs are not listed) but obviously there are likely to be a few more changes before 1.0
  • The text section could be improved, but I'll do that with a fresher brain

@jku jku requested a review from ivanayov February 9, 2022 14:11
@coveralls
Copy link

coveralls commented Feb 9, 2022

Pull Request Test Coverage Report for Build 1863174413

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.574%

Totals Coverage Status
Change from base Build 1852769022: 0.2%
Covered Lines: 1095
Relevant Lines: 1107

💛 - Coveralls

Copy link
Collaborator

@ivanayov ivanayov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like almost everything is present. Leaving some minor comments.

Should we add bug fixes?

docs/CHANGELOG.md Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@jku
Copy link
Member Author

jku commented Feb 11, 2022

Should we add bug fixes?

They should be in the list, just with the PR number and not the issue number (I can see an argument for using issue numbers: it's just potentially a lot more work since git log --merges v0.20.0..origin/develop gives a good initial list of PRs, but a complete list of issues is much harder to collect).

Out of your list all others have PRs in the list except 1754 and 1478: the latter was "fixed" last summer already but the former does seem to have the wrong issue number in the changelog. Thanks!

I fixed that and rebased to include the latest PRs 1850, 1848, 1855, 1809.

@ivanayov
Copy link
Collaborator

It looks good this way as well (i.e. without specific "Bug fixes" section).

I think that after having all latest required PRs merged (including the not yet opened for #1852) this should be good to go.

@jku
Copy link
Member Author

jku commented Feb 14, 2022

rebased, added a commit that documents the new PRs in that rebase (this can be squashed, just trying to make this easier to review)

@ivanayov
Copy link
Collaborator

Looks good to me.

@jku jku linked an issue Feb 18, 2022 that may be closed by this pull request
Jussi Kukkonen added 3 commits February 18, 2022 09:37
@jku
Copy link
Member Author

jku commented Feb 18, 2022

rebased again, added a commit that documents the new merges in that rebase (this can be squashed, just trying to make this easier to review)

Copy link
Collaborator

@MVrachev MVrachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at all commits after release 0.20.0 and it seems that all changes are here.
LGTM!

@jku jku mentioned this pull request Feb 18, 2022
@lukpueh
Copy link
Member

lukpueh commented Feb 18, 2022

Superseded by #1873

@lukpueh lukpueh closed this Feb 18, 2022
@jku jku deleted the changelog-1.0 branch December 30, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write 1.0 changelog / release notes
5 participants