1.0.0 release #1873
Merged
1.0.0 release #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
force pushed to add my signed-off-bys to Lukas commits |
Pull Request Test Coverage Report for Build 1864618423Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
lukpueh
reviewed
Feb 18, 2022
| @@ -1,6 +1,6 @@ | |||
| [metadata] | |||
| name = tuf | |||
| version = 0.20.0 | |||
| version = 1.0.0 | |||
|
Nit: Mind squashing my two doc commits into one? |
This was referenced Feb 18, 2022
Change docs in preparation of close v1.0.0 release. - Remove important notice about upcoming 1.0.0 release from README - Reword 1.0.0-ANNOUNCEMENT.md to not sound outdated after release Co-authored-by: Joshua Lock <[email protected]> Signed-off-by: Jussi Kukkonen <[email protected]>
Metadata API defines a specification version it supports already, and that one is updated to the actual specification version we produce. Signed-off-by: Jussi Kukkonen <[email protected]>
* Update Changelog * Update version numbers Signed-off-by: Jussi Kukkonen <[email protected]>
|
force-pushed: no changes, but squashed a commit to one. |
This was
linked to
issues
Feb 18, 2022
lukpueh
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Just to make sure, are the following PRs not mentioned in the changelog on purpose, due to insignificance?
- Metadata API: Add missing space in 2 err messages #1765
- Remove TODOs about too-many-arguments #1794
- ngclient: Remove obsolete TODOs #1805
- Fix a new space warning by black #1814
- github: disable pip caching temporarily #1821
- README: Fix CI badge #1823
- Revert "github: disable pip caching temporarily" #1824
They were all merged after our last release 0.20.0
git log --oneline --merges v0.20.0..HEAD | egrep -o --color=never "Merge pull request #[0-9]+" | cut -d" " -f4
|
yes, looks correct -- I don't object to including them, they just seemed not relevant |
lukpueh
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
🎉 Thanks for preparing the release, @jku!
Here's what I did to review: I checked that
- the already approved #1869 is fully included in this PR,
- all significant PRs are included in the changelog (see comment above),
- all changelog items list the corresponding PRs,
- and I proof-read the changelog
|
I'll have another quick look and will then get this done... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains:
I think it makes sense to do the last two here and close the other PRs without merging -- the constant removal could be dropped as I mentioned.
I'm running release tests now, but review is welcome