Unit test infrastructure fixes #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually want to return anything here: just make sure download_file() gets executed Signed-off-by: Jussi Kukkonen <[email protected]>
Pull Request Test Coverage Report for Build 12273900862Details
💛 - Coveralls |
jku
force-pushed
the
test-fixes
branch
2 times, most recently
from
a03b59e to
276200f
Compare
This was essentially unused now (originally it was used to randomize the test order). Signed-off-by: Jussi Kukkonen <[email protected]>
"python -m unittest" now works in the root source dir too Signed-off-by: Jussi Kukkonen <[email protected]>
This was only needed because tests needed changing to tests/ dir: this is no longer the case. Signed-off-by: Jussi Kukkonen <[email protected]>
Tests now run from root dir so various coverage complications can be removed. Also remove the duplicate .coveragerc and rely on pyproject.toml Signed-off-by: Jussi Kukkonen <[email protected]>
We always want to either verify or generate new results: don't have multiple arguments. Also fix annotated types. Signed-off-by: Jussi Kukkonen <[email protected]>
This was likely only necessary because the test suite required it: Now tuf does not get installed at all by tox (or by dev install) Signed-off-by: Jussi Kukkonen <[email protected]>
jku
commented
Dec 11, 2024
This was in use in tests/.coveragerc: previously. Enable in pyproject config too. Signed-off-by: Jussi Kukkonen <[email protected]>
This is because CI + coveralls was not using the pyproject config before this so some relevant excludes were not getting picked up previously when running coverage there |
|
Adding to my TODO |
kairoaraujo
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor unit test infra. The goal is to remove workarounds and enable testing outside the project:
cd test/ && python ./aggregate_tests.pyhack: this is non-standard and leads to endless problems. Instead allow the test suite to run from source rootaggregate_tests.pyitself has no real functionality and can be removed (it used to handle test run order randomization but that has been removed already)pyproject.tomlFixes #2745