Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test infrastructure fixes #2749

Merged
merged 8 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_FLAG_NAME: ${{ runner.os }} / Python ${{ matrix.python-version }}
COVERALLS_PARALLEL: true
# Use cp workaround to publish coverage reports with relative paths
# FIXME: Consider refactoring the tests to not require the test
# aggregation script being invoked from the `tests` directory, so
# that `.coverage` is written to and .coveragrc can also reside in
# the project root directory as is the convention.
run: |
cp tests/.coverage .
coveralls --service=github --rcfile=tests/.coveragerc
coveralls --service=github

coveralls-fin:
# Always run when all 'tests' jobs have finished even if they failed
Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,8 @@ exclude_also = [
"raise AssertionError",
# imports for mypy only
"if TYPE_CHECKING",
]
[tool.coverage.run]
omit = [
"tests/*",
]
13 changes: 0 additions & 13 deletions tests/.coveragerc

This file was deleted.

7 changes: 2 additions & 5 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ skipsdist = true
commands =
python3 --version
python3 -m coverage run -m unittest
python3 -m coverage report --rcfile {toxinidir}/pyproject.toml -m --fail-under 97
python3 -m coverage report -m --fail-under 97

deps =
-r{toxinidir}/requirements/test.txt
Expand All @@ -33,10 +33,9 @@ commands_pre =

commands =
python3 -m coverage run -m unittest
python3 -m coverage report --rcfile {toxinidir}/pyproject.toml -m
python3 -m coverage report -m

[testenv:lint]
changedir = {toxinidir}
deps =
-r{toxinidir}/requirements/lint.txt
--editable {toxinidir}
Expand All @@ -49,7 +48,6 @@ commands =
mypy {[testenv:lint]lint_dirs}

[testenv:fix]
changedir = {toxinidir}
deps = {[testenv:lint]deps}
commands =
ruff check --fix {[testenv:lint]lint_dirs}
Expand All @@ -59,6 +57,5 @@ commands =
deps =
-r{toxinidir}/requirements/docs.txt

changedir = {toxinidir}
commands =
sphinx-build -b html docs docs/build/html -W