Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Update erc1155 airdrop form #5127

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 22, 2024

  • Remove tw-component's Drawer
  • Consolidate some shared code
  • Remove an useEffect

PR-Codex overview

This PR focuses on refactoring the airdrop functionality in a dashboard application. It consolidates the handling of airdrop addresses into a unified structure and updates related components to improve code clarity and maintainability.

Detailed summary

  • Renamed ERC20AirdropAddressInput to AirdropAddressInput.
  • Updated AirdropUpload component to use the new AirdropAddressInput type.
  • Modified function signatures and internal logic to accommodate the new type.
  • Adjusted UI components to improve layout and responsiveness.
  • Replaced AirdropUploadERC20 with AirdropUpload in relevant files.
  • Enhanced error handling and user notifications during the airdrop process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 7:42pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 24, 2024 7:42pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 24, 2024 7:42pm
wallet-ui ⬜️ Skipped (Inspect) Oct 24, 2024 7:42pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 18:18 Inactive
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: cf36a33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 18:18 Inactive
Copy link

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 22, 2024
@kien-ngo kien-ngo changed the title Update erc1155 airdrop form [Dashboard] Update erc1155 airdrop form Oct 22, 2024
Copy link
Contributor Author

kien-ngo commented Oct 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo marked this pull request as ready for review October 22, 2024 18:19
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 18:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 18:20 Inactive
@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 22, 2024 — with Graphite App
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.42%. Comparing base (2fdb69d) to head (cf36a33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5127   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files        1065     1065           
  Lines       55145    55145           
  Branches     3970     3970           
=======================================
  Hits        25049    25049           
  Misses      29404    29404           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2fdb69d
packages 40.44% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.2 s (-4.84% 🔽) 4.1 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 7.5 s (+26.06% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 236 ms (+13.14% 🔺) 332 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 86 ms (-5.9% 🔽) 96 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 721 ms (-17.86% 🔽) 1.1 s

Copy link

graphite-app bot commented Oct 24, 2024

Merge activity

- [x] Remove tw-component's Drawer
- [x] Consolidate some shared code
- [x] Remove an useEffect

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the airdrop functionality in a dashboard application, improving the handling of token and NFT airdrops by consolidating interfaces and components.

### Detailed summary
- Renamed `ERC20AirdropAddressInput` to `AirdropAddressInput`.
- Updated `AirdropUploadERC20` to `AirdropUpload`.
- Adjusted state management for airdrop data.
- Simplified CSV data processing.
- Enhanced error handling during transaction processes.
- Replaced modal with `Sheet` component for airdrop interface.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants