Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Add batch claim feature <dont auto merge> #5154

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 24, 2024

image.png


PR-Codex overview

This PR introduces enhancements to the airdrop functionality across various components, allowing for optional removal of duplicate addresses and improving the user interface for claiming NFTs.

Detailed summary

  • Added removeDuplicateAddresses prop to AirdropUploadProps.
  • Implemented logic to filter out duplicate addresses in processAirdropData.
  • Updated AirdropUpload to handle duplicate addresses.
  • Introduced SingleClaimTab and BatchClaimTab for NFT claiming.
  • Improved UI with tabbed navigation for single and batch claims.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 1:13pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 27, 2024 1:13pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 27, 2024 1:13pm
wallet-ui ⬜️ Skipped (Inspect) Oct 27, 2024 1:13pm

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 37c8282

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

kien-ngo commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 24, 2024
@kien-ngo kien-ngo changed the title adjust test [Dashboard] Add batch claim feature Oct 24, 2024
@kien-ngo kien-ngo marked this pull request as ready for review October 24, 2024 08:18
@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 24, 2024 — with Graphite App
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 851 ms (+12.85% 🔺) 1.8 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 2.3 s (+27.83% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 121 ms (+149.24% 🔺) 217 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 235 ms (+1803.23% 🔺) 245 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 640 ms (+111.41% 🔺) 987 ms

@kien-ngo
Copy link
Contributor Author

DASH-343

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (a365dd8) to head (37c8282).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5154   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1068     1068           
  Lines       55230    55230           
  Branches     3970     3970           
=======================================
  Hits        25055    25055           
  Misses      29483    29483           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a365dd8
packages 40.38% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the base branch from graphite-base/5154 to main October 24, 2024 19:44
@kien-ngo kien-ngo changed the title [Dashboard] Add batch claim feature [Dashboard] Add batch claim feature <dont auto merge> Oct 24, 2024
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 24, 2024 19:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 24, 2024 19:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 24, 2024 19:46 Inactive
Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring the review to @jnsdls for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants