Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): format hesai launch #383

Merged
merged 2 commits into from
Jan 30, 2025
Merged

chore(common): format hesai launch #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9e772
explicit declaration for max_range param in hesai_XT32.launch.xml
Autumn60 Jan 30, 2025
f036b9e
sort params in hesai_*.launch.xml
Autumn60 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common_sensor_launch/launch/hesai_OT128.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
<include file="$(find-pkg-share common_sensor_launch)/launch/nebula_node_container.launch.py">
<arg name="launch_driver" value="$(var launch_driver)"/>
<arg name="sensor_model" value="$(var model)"/>
<arg name="return_mode" value="$(var return_mode)"/>
<arg name="frame_id" value="$(var sensor_frame)"/>
<arg name="return_mode" value="$(var return_mode)"/>
<arg name="sensor_ip" value="$(var sensor_ip)"/>
<arg name="host_ip" value="$(var host_ip)"/>
<arg name="data_port" value="$(var data_port)"/>
Expand All @@ -29,9 +29,9 @@
<arg name="cloud_max_angle" value="$(var cloud_max_angle)"/>
<arg name="dual_return_distance_threshold" value="$(var dual_return_distance_threshold)"/>
<arg name="vehicle_mirror_param_file" value="$(var vehicle_mirror_param_file)"/>
<arg name="container_name" value="$(var container_name)"/>
<arg name="use_intra_process" value="true"/>
<arg name="use_multithread" value="true"/>
<arg name="container_name" value="$(var container_name)"/>
<arg name="ptp_profile" value="automotive"/>
<arg name="ptp_transport_type" value="L2"/>
<arg name="ptp_switch_type" value="NON_TSN"/>
Expand Down
5 changes: 3 additions & 2 deletions common_sensor_launch/launch/hesai_XT32.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,16 @@
<arg name="scan_phase" default="0.0"/>
<arg name="cloud_min_angle" default="0"/>
<arg name="cloud_max_angle" default="360"/>
<arg name="max_range" default="120.0"/>
<arg name="dual_return_distance_threshold" default="0.1"/>
<arg name="vehicle_mirror_param_file"/>
<arg name="container_name" default="hesai_node_container"/>

<include file="$(find-pkg-share common_sensor_launch)/launch/nebula_node_container.launch.py">
<arg name="launch_driver" value="$(var launch_driver)"/>
<arg name="sensor_model" value="$(var model)"/>
<arg name="return_mode" value="$(var return_mode)"/>
<arg name="frame_id" value="$(var sensor_frame)"/>
<arg name="return_mode" value="$(var return_mode)"/>
<arg name="sensor_ip" value="$(var sensor_ip)"/>
<arg name="host_ip" value="$(var host_ip)"/>
<arg name="data_port" value="$(var data_port)"/>
Expand All @@ -30,13 +31,13 @@
<arg name="max_range" value="$(var max_range)"/>
<arg name="dual_return_distance_threshold" value="$(var dual_return_distance_threshold)"/>
<arg name="vehicle_mirror_param_file" value="$(var vehicle_mirror_param_file)"/>
<arg name="container_name" value="$(var container_name)"/>
<arg name="use_intra_process" value="true"/>
<arg name="use_multithread" value="true"/>
<arg name="ptp_profile" value="automotive"/>
<arg name="ptp_switch_type" value="NON_TSN"/>
<arg name="ptp_transport_type" value="L2"/>
<arg name="setup_sensor" value="true"/>
<arg name="retry_hw" value="true"/>
<arg name="container_name" value="$(var container_name)"/>
</include>
</launch>
Loading