Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hesai): make tracking a WARNing instead of an ERROR #242

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Nov 29, 2024

PR Type

  • Improvement

Related Links

Description

With this PR, the diagnostics status for hesai_ptp is set to WARN, not ERROR when ptp_status is tracking. Hesai's user manuals state that tracking still counts as synchronized, so Nebula should not report it as an error.

Since tracking can be a symptom of non-perfect PTP setups, the warning comes with a status message synchronized, degraded.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d42cd0) to head (60d2351).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nebula_ros/src/hesai/hw_monitor_wrapper.cpp 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3d42cd0) and HEAD (60d2351). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (3d42cd0) HEAD (60d2351)
total 4 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #242       +/-   ##
==========================================
- Coverage   26.11%   0.00%   -26.12%     
==========================================
  Files         101      88       -13     
  Lines        9212    7872     -1340     
  Branches     2211     939     -1272     
==========================================
- Hits         2406       0     -2406     
- Misses       6417    7872     +1455     
+ Partials      389       0      -389     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kotaro-hihara kotaro-hihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojomex mojomex merged commit 4e1c5ce into main Nov 29, 2024
11 of 13 checks passed
@mojomex mojomex deleted the chore/hesai-ptp-tracking-as-warning branch November 29, 2024 07:10
kotaro-hihara pushed a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants