Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hesai): replace broadcast host_ip #256

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Feb 3, 2025

PR Type

  • Improvement

Related Links

Description

Replace the the host_ip default config parameter with one that is not the broadcast address - broadcast is disallowed by Nebula since #231.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Replace the the `host_ip` default config parameter fith one  that is not the broadcast address - broadcast is disallowed by Nebula since #231

Signed-off-by: Max SCHMELLER <[email protected]>
mojomex added a commit that referenced this pull request Feb 3, 2025
commit d14c183
Author: Max SCHMELLER <[email protected]>
Date:   Mon Feb 3 19:11:10 2025 +0900

    chore(hesai): replace broadcast `host_ip`

    Replace the the `host_ip` default config parameter fith one  that is not the broadcast address - broadcast is disallowed by Nebula since #231

    Signed-off-by: Max SCHMELLER <[email protected]>

Signed-off-by: Max SCHMELLER <[email protected]>
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f4da047) to head (d14c183).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f4da047) and HEAD (d14c183). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (f4da047) HEAD (d14c183)
total 4 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #256       +/-   ##
==========================================
- Coverage   27.24%   0.00%   -27.25%     
==========================================
  Files         104      91       -13     
  Lines        9445    8093     -1352     
  Branches     2324     973     -1351     
==========================================
- Hits         2573       0     -2573     
- Misses       6436    8093     +1657     
+ Partials      436       0      -436     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex requested a review from drwnz February 4, 2025 01:38
@mojomex mojomex self-assigned this Feb 4, 2025
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mojomex mojomex merged commit bd8b507 into main Feb 4, 2025
11 of 12 checks passed
@mojomex mojomex deleted the chore/hesai-no-broadcast-hosts branch February 4, 2025 02:05
mojomex added a commit that referenced this pull request Feb 4, 2025
mojomex added a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants