-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hesai): replace broadcast host_ip
#256
Conversation
Replace the the `host_ip` default config parameter fith one that is not the broadcast address - broadcast is disallowed by Nebula since #231 Signed-off-by: Max SCHMELLER <[email protected]>
commit d14c183 Author: Max SCHMELLER <[email protected]> Date: Mon Feb 3 19:11:10 2025 +0900 chore(hesai): replace broadcast `host_ip` Replace the the `host_ip` default config parameter fith one that is not the broadcast address - broadcast is disallowed by Nebula since #231 Signed-off-by: Max SCHMELLER <[email protected]> Signed-off-by: Max SCHMELLER <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 27.24% 0.00% -27.25%
==========================================
Files 104 91 -13
Lines 9445 8093 -1352
Branches 2324 973 -1351
==========================================
- Hits 2573 0 -2573
- Misses 6436 8093 +1657
+ Partials 436 0 -436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…256 Signed-off-by: Max SCHMELLER <[email protected]>
…256 Signed-off-by: Max SCHMELLER <[email protected]>
PR Type
Related Links
host_ip
Description
Replace the the
host_ip
default config parameter with one that is not the broadcast address - broadcast is disallowed by Nebula since #231.Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks