feat(component): add nonRerendering option to element factory #9295
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
CatsJuice,
EYHN,
forehalo,
pengx17 and
JimmFly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #9295 +/- ##
==========================================
+ Coverage 51.76% 51.79% +0.02%
==========================================
Files 2148 2147 -1
Lines 97630 97497 -133
Branches 16332 16284 -48
==========================================
- Hits 50543 50499 -44
+ Misses 45772 45686 -86
+ Partials 1315 1312 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| (elementOrFactory: React.ReactElement | (() => React.ReactElement)) => { | ||
| ( | ||
| elementOrFactory: React.ReactElement | (() => React.ReactElement), | ||
| nonRerendering?: boolean |
fundon
deleted the
fundon/12_24_add_nonRerendering_option_to_element_factory
branch
* removes `listeners` * adds `notify` property into `LitReactPortal` * adds `rerendering` argument to element factory Related to #9295 (comment)
Closes: AF-2018
In the
pdf embed viewscenario, we don't need to refresh like inline links.