add confirmation to mark all as unread or read #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dialog uses the existing action item strings for the title, to avoid adding too many new strings (that need translation for i8n)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change we discussed in #342.
For the confirmation dialog, I used the existing action labels for the title, to avoid adding too many new strings (needing translation for i8n).
Let me know what you think of the dialog phrasing, for both the message and positive button label. I put the same text for both "read" and "unread" dialogs, as the end result is similar: the user is clearing their history of read/unread items.
I tested this change on my phone, using the "Earliest unread" action to see the true read/unread state. I wasn't able to see immediate updates in the overview list (compact cards), but I believe that behavior is the same without this update.