Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add confirmation to mark all as unread or read #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add confirmation to mark all as unread or read #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Unreleased

- Add confirmation to mark all as unread or read

## 8.5

- Double tapping a comic zooms to where you tapped (instead of simply to the image center)
Expand Down
21 changes: 19 additions & 2 deletions app/src/main/java/de/tap/easy_xkcd/comicOverview/ComicOverviewFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,11 +268,28 @@ class ComicOverviewFragment : Fragment() {
true
}
R.id.action_unread -> {
model.setAllRead(false)
AlertDialog.Builder(requireContext()).setTitle(R.string.action_unread)
.setMessage(R.string.clear_all_read_confirm)
.setPositiveButton(R.string.clear_confirm) { dialogInterface, _ ->
model.setAllRead(false)
dialogInterface.dismiss()
}
.setNegativeButton(R.string.dialog_cancel) { dialogInterface, _ ->
dialogInterface.dismiss()
}.show()
true
}
R.id.action_all_read -> {
model.setAllRead(true)
AlertDialog.Builder(requireContext()).setTitle(R.string.action_all_read)
.setMessage(R.string.clear_all_read_confirm)
.setPositiveButton(R.string.clear_confirm) { dialogInterface, _ ->
model.setAllRead(true)
dialogInterface.dismiss()
}
.setNegativeButton(R.string.dialog_cancel) { dialogInterface, _ ->
dialogInterface.dismiss()
}
.show()
true
}
R.id.action_hide_read -> {
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
<string name="favorites_cleared">Favorites cleared</string>
<string name="delete_offline_dialog">Are you sure you want to disable Offline Mode? This will delete all saved images(except favorites)</string>
<string name="delete_offline_whatif_dialog">Are you sure you want to disable Offline Mode? This will delete all saved articles</string>
<string name="clear_all_read_confirm">All read progress will be lost.</string>
<string name="clear_confirm">Clear</string>

<string name="share_url">Share url with&#8230;</string>
<string name="share_image">Share image with&#8230;</string>
Expand Down