Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-image): rename Image -> SuspenseImage #554

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Jan 4, 2024

fix #395

Overview

I rename Image -> SuspenseImage

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@manudeli manudeli self-assigned this Jan 4, 2024
Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: a7e5ea4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@suspensive/react-image Patch
@suspensive/visualization Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 3:22pm
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 3:22pm
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 3:22pm

@manudeli manudeli marked this pull request as ready for review January 4, 2024 15:19
@vercel vercel bot temporarily deployed to Preview – visualization January 4, 2024 15:19 Inactive
Copy link

codesandbox-ci bot commented Jan 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #554 (a7e5ea4) into main (28a005c) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   84.33%   84.15%   -0.19%     
==========================================
  Files          29       29              
  Lines         466      467       +1     
  Branches      108      108              
==========================================
  Hits          393      393              
- Misses         63       64       +1     
  Partials       10       10              
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query 0.00% <ø> (ø)
@suspensive/react-await 100.00% <ø> (ø)
@suspensive/react-image 23.52% <0.00%> (-0.48%) ⬇️

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 4, 2024 15:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v1 January 4, 2024 15:22 Inactive
Copy link
Member

@minsoo-web minsoo-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Lets Go!!

@minsoo-web minsoo-web merged commit 05a3534 into main Jan 4, 2024
18 checks passed
@minsoo-web minsoo-web deleted the react-image/refactor/rename-image branch January 4, 2024 16:24
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #395

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I rename Image -> SuspenseImage

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #395

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I rename Image -> SuspenseImage

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #395

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I rename Image -> SuspenseImage

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #395

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I rename Image -> SuspenseImage

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: differ JavaScript's Image object and @suspensive/react-image Image
2 participants