-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tutorial/api-fetching): improve text and snippet code #40
Conversation
8a76b21
to
4743602
Compare
api-fetching.mdx
api-fetching.mdx
d0e5bd7
to
33ded3f
Compare
api-fetching.mdx
api-fetching.mdx
api-fetching.mdx
Thanks @nicolasgasco! |
This comment was marked as resolved.
This comment was marked as resolved.
@marcalexiei it's not raising any diff when I run it 🤔 |
c886cc5
to
110a82d
Compare
110a82d
to
b3a64ff
Compare
It seems like you’ve changed the code, so the formatting error is no longer present. Side note: Could you please avoid using force pushes in the future? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here. I've added a few suggestions just to make it a bit smoother to read, but apart from that, looks great!
Co-authored-by: Jacob Marshall <[email protected]>
Co-authored-by: Jacob Marshall <[email protected]>
@marcalexiei Absolutely, sorry for that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks again for your work on this.
When you have the change check #42 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related issue
None
Overview
With this small PR, I'd like to introduce some small tweaks to text of the API fetching page of the tutorial.
Some of the changes are typo and grammar fixes, while some others are more subjective, but they all contribute (at least in my opinion) to making the page more pleasant to read.
I included a small tweak to the
tsx
snippet as well in order to:index
forkey
, since it's not considered a good practice and the Pokemons names are a better candidate