Ethical: Add ethical report URI to datamodel and DO, that can be disabled throught the config file #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyKarnbach
changed the title
|
GeoffreyKarnbach
force-pushed
the
gk/292-ethics-add-ethical-issues-report-to-damap
branch
2 times, most recently
from
5d20510 to
5ebadbf
Compare
src/main/resources/org/damap/base/db/changeLog-4.x/changeLog-4.3.0_4.yaml
Outdated
Show resolved
Hide resolved
|
Looks pretty good overall, but i have a few things to add. First off, we have changed the dataytpe to string, so i would remove all mentions of URL or URI and just rename it to ethical issues report, like in the standard. I dont know why you touched the HE and SE templates, please add the review documents. In the same vein, could you add Changelog statements to the PR, since this PR touched the templates, the resource files and added new functionality that can be disabled (all interesting things for maintainers) |
GeoffreyKarnbach
force-pushed
the
gk/292-ethics-add-ethical-issues-report-to-damap
branch
2 times, most recently
from
bb87a20 to
c54fb57
Compare
…bled throught the config file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature
What does this PR do?
Add new Ethical Report URI field in the DB, DO. Possibility to disable it using the application.yaml file using the ConfigDO sent to the frontend.
Dependencies
Related Fronted PR
closes GH-292