Ethical: Add new ethical report uri field to frontend (disableable from the backend) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyKarnbach
force-pushed
the
gk/382-ethics-add-ethical-issues-report-to-damap
branch
2 times, most recently
from
1d82403 to
1fe8af0
Compare
|
GeoffreyKarnbach
force-pushed
the
gk/382-ethics-add-ethical-issues-report-to-damap
branch
2 times, most recently
from
e8cd598 to
17df067
Compare
|
Good work, the validators will also prove useful in the future! Only one thing, like in the backend. Can you remove the mentions of URI and URL and rename them to ethical issues report like in the standard? |
GeoffreyKarnbach
force-pushed
the
gk/382-ethics-add-ethical-issues-report-to-damap
branch
4 times, most recently
from
82a4f9a to
bede4e2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature
What does this PR do?
Add new ethical report URI field in the frontend step 6 ("Ethical aspects" view), the input field is only being displayed if it is not disabled through the config and if the Question "Was your research plan reviewed by an ethics committee, the Ethics Committee of your institution , or a similar body?" has been answered with yes.
A new URI and URL Validator have been introduced in a reusable manner.
Dependencies
Related Backend PR
closes GH-382