fix broken link to Extension-Rig-Banner.png #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
reviewed
Jul 15, 2022
| @@ -9,7 +9,7 @@ | |||
| This guide will cover the fundamentals of building your first Extension. It will allow Twitch viewers to cycle through colors via a visual element added on top of the video player (we call this a component overlay). On the frontend, a user clicks a button in this component that changes the color of a circle. Instead of changing the CSS locally, it makes a call to a backend server for a new hex value (we call this an Extension Backend Service or EBS for short). | |||
|
|
|||
| ## What's the Twitch Developer Rig? | |||
| <img src="https://github.com/twitchdev/extension-getting-started/blob/master/Extension-Rig-Banner.png" width="45%"> | |||
| <img src="https://github.com/twitchdev/extension-getting-started/raw/main/Extension-Rig-Banner.png" width="45%"> | |||
There was a problem hiding this comment.
This change is an improvement: it works in the PR view where the existing one doesn't. 👍
But I think we can simplify it further. Since the image is stored in the same location as this README, we should be able to use a relative link.
Suggested change
| <img src="https://github.com/twitchdev/extension-getting-started/raw/main/Extension-Rig-Banner.png" width="45%"> | |
| <img src="Extension-Rig-Banner.png" width="45%"> |
This frees us from worrying about which host github is using for images or what the branch is named.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.