Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link to Extension-Rig-Banner.png #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
This guide will cover the fundamentals of building your first Extension. It will allow Twitch viewers to cycle through colors via a visual element added on top of the video player (we call this a component overlay). On the frontend, a user clicks a button in this component that changes the color of a circle. Instead of changing the CSS locally, it makes a call to a backend server for a new hex value (we call this an Extension Backend Service or EBS for short).

## What's the Twitch Developer Rig?
<img src="https://github.com/twitchdev/extension-getting-started/blob/master/Extension-Rig-Banner.png" width="45%">
<img src="https://github.com/twitchdev/extension-getting-started/raw/main/Extension-Rig-Banner.png" width="45%">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is an improvement: it works in the PR view where the existing one doesn't. 👍

But I think we can simplify it further. Since the image is stored in the same location as this README, we should be able to use a relative link.

Suggested change
<img src="https://github.com/twitchdev/extension-getting-started/raw/main/Extension-Rig-Banner.png" width="45%">
<img src="Extension-Rig-Banner.png" width="45%">

This frees us from worrying about which host github is using for images or what the branch is named.


The recommended path for building this sample is with the Twitch Developer Rig. This is a native application to help with your development. The following steps will help you download, install, and set up the Rig.

Expand Down