-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notify self assign #24
feat: notify self assign #24
Conversation
# Conflicts: # manifest.json # src/worker.ts # yarn.lock
New QA: Meniole#10 (comment) |
# Conflicts: # tests/main.test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be an issue with posting error comments
Is it directly related to this pull-request or not? If so I will fix here, if not I'll do that on another PR. |
Odd that the Proxy messed with bubbling up the error that's something I'll need to look into in for a I swear I don't use Microsoft Copilotand Is this intended? I guess this is a separate issue below. But didn't we used to give a buffer as opposed to using the raw time string? I bring this up because if contributors start to get negative XP for being beyond the deadline or lesser rewards because of it then surely the opposite should be true for tasks which get "completed" within the deadline. "Completed" is also subjective here, is that time til PR or time til closed-as-complete? |
@Keyrxng time is given in UTC, so I don't know the time zone you are in but that should be the reason. If not, I didn't change the code logic (I think) to get the deadline: https://github.com/ubiquibot/command-start-stop/pull/24/files#diff-0d8c330f3d4a9c9fe27deaf9eb73ede2d9bb6016940d6d24cd112688d819ecf5L15 And I think completed should be PR opening + ready to review, being merged in 1 hours sounds unrealistic. |
That'll be my mistake then my bad. My timezone is UTC+00 which I'm sure is the same as the reminder, do you think you could add a
Agreed lol. And with issue/PR activity bumping it forward technically it's not a strict deadline either so calculating a bonus/negative based on the deadline seems like it will be a difficult task actually. |
@Keyrxng sure I can check that time issue and add some tests within a separate pull request. Probably should use some averages / lean methods for xp calculations. |
2be6491
into
ubiquity-os-marketplace:development
What is this about timing and XP? There is no approved proposal related to this. XP is derived only from dollar rewards, plus adjustments. No dollar rewards are related to deadlines and timing. |
Resolves #12
Depends on #21, #19
QA: Meniole#1 (comment)