Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bie fix #60

Merged
merged 22 commits into from
Aug 15, 2024
Merged

Bie fix #60

merged 22 commits into from
Aug 15, 2024

Conversation

ctr26
Copy link
Collaborator

@ctr26 ctr26 commented Aug 15, 2024

Pull Request Summary

  • Collator Class:

    • The previous collate_fn was occasionally causing issues with PyTorch Lightning. A new collator class has been introduced in the hope of improving this functionality.
  • Loss Function Handling:

    • Removed the separate loss_function from eval_step as it was too confusing.
    • Variational loss is now recorded manually.
    • Shape loss will also need to be manually added to loss_dict if it is to be recorded.
    • Although mutating objects feels a bit icky, it’s the cleanest approach for readability.
    • Ideally, a specific Loss object that inherits from ModelOutput would be preferred.
  • Evaluation Step:

    • eval_step must still call super() for mixins to function properly.
  • Test Improvements:

    • Tests have been updated to be more future-proof, sensible, and to use configuration signatures in case they change.
    • The tests now better reflect how users should interact with the code.
  • Jupytext & Notebooks:

    • Added a jupytext.toml for notebooks and included a basic notebook file (simple.py) in the scripts directory.

@ctr26 ctr26 merged commit 6974ac2 into master Aug 15, 2024
2 checks passed
@ctr26 ctr26 deleted the bie_fix branch August 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant