Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22721 Cherry-pick MinGW CI bugfix to maint-75 #3011

Merged
merged 1 commit into from
May 16, 2024
Merged

ICU-22721 Cherry-pick MinGW CI bugfix to maint-75 #3011

merged 1 commit into from
May 16, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented May 16, 2024

This is a cherry-pick of commit 564c92d.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22721
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@roubert
ICU-22721 Delete obsolete __STRICT_ANSI__ workaround for MinGW.
9bdf844 
This was originally added in the year 2004 for ICU-3854 but is no longer
needed with contemporary versions of MinGW where it instead as of GCC 14
causes this problem:

__STRICT_ANSI__ seems to have been undefined; this is not supported.
@roubert roubert mentioned this pull request May 16, 2024
Merged
7 tasks
@roubert roubert requested a review from markusicu May 16, 2024 13:41
markusicu
markusicu approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@roubert roubert merged commit 43b0901 into unicode-org:maint/maint-75 May 16, 2024
97 checks passed
@roubert roubert deleted the mingw branch May 16, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roubert @markusicu