Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install build tools to manually install both #29

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Nov 8, 2023

GTest and CMake to avoid version issues accross different ubuntu distributions

PR Details

Description

Update carma-builds images to install fixed versions of CMake and google test to avoid version conflicts caused by apt install in different ubuntu distributions.

Related GitHub Issue

Related Jira Key

CDAR-389

Motivation and Context

Install both CMake and GTest without apt, manually to ensure that all debian distro base images share the same version. This is all in an effort to create carma-build images for bionic to allow stol apt debian packages to be available for services built of ubuntu bionic distribution. Specifically for VRU UC 1 we need a new CARMA Streets service called the Sensor Data Sharing Service to have access to our carma-time-lib library and to have lanelet2 installed which we currently have only implemented from a bionic base image for carma-streets services.

How Has This Been Tested?

CI/CD and local docker builds

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

GTest and CMake to avoid version issues accross different ubuntu
distributions
@paulbourelly999 paulbourelly999 marked this pull request as ready for review November 9, 2023 14:45
scripts/install_build_tools.sh Outdated Show resolved Hide resolved
scripts/install_build_tools.sh Show resolved Hide resolved
scripts/install_build_tools.sh Outdated Show resolved Hide resolved
scripts/install_build_tools.sh Outdated Show resolved Hide resolved
scripts/install_build_tools.sh Show resolved Hide resolved
scripts/install_build_tools.sh Outdated Show resolved Hide resolved
@adamlm adamlm merged commit c0a43ff into develop Nov 9, 2023
14 checks passed
@adamlm adamlm deleted the fix/install_cmake_gtest_manually branch November 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants