Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cmake install for interactive/non-interaction shell #30

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Nov 9, 2023

PR Details

Description

Fix CMake installation to not require custom path so it works in both interactive and non-interactive shells and does not require sourcing specific scripts

Related GitHub Issue

Related Jira Key

CDAR-389

Motivation and Context

Fix CMake installation to not require custom path so it works in both interactive and non-interactive shells and does not require sourcing specific scripts

Local testing with docker images

How Has This Been Tested?

Types of changes

  • [x ] Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adamlm adamlm merged commit c54af8a into develop Nov 10, 2023
14 checks passed
@adamlm adamlm deleted the fix/cmake_install branch November 10, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants