Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci master feature tag #33

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Apr 9, 2024

PR Details

Description

Currently for the master branch the CI incorrectly tags all docker images built with the tag master (https://github.com/usdot-fhwa-stol/carma-builds/actions/runs/8616180408). This makes it almost impossible to grab the correct image for since all images are pushed to the same tag for the matrix build. I have fixed the CI to correctly push images as

{{branch-name}}-{{ubuntu-distribution}} (feature branches)
{{tag-name}}-{{ubuntu-distribtution}} (tags) (https://github.com/usdot-fhwa-stol/carma-builds/actions/runs/8622519533)
master-{{ubuntu-distribution}} (master) (https://github.com/usdot-fhwa-stol/carma-builds/actions/runs/8622513111/job/23633788788)
{{ubuntu-distribution}} (develop)

Related GitHub Issue

Related Jira Key

Motivation and Context

Setup correct CI processes

How Has This Been Tested?

CI

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 requested a review from MishkaMN April 9, 2024 21:34
@paulbourelly999 paulbourelly999 self-assigned this Apr 9, 2024
@paulbourelly999 paulbourelly999 merged commit 95cf37d into master Apr 9, 2024
21 checks passed
@paulbourelly999 paulbourelly999 deleted the fix_ci_master_feature_tag branch April 9, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants