Fix ARM Focal Cross Compilation issues #36
Conversation
| @@ -32,7 +33,7 @@ COPY cross/add_cross_architecture_ports.sh / | |||
| RUN /add_cross_architecture_ports.sh | |||
|
|
|||
| # install the cross compiler | |||
| RUN apt-get update && apt-get install -y cmake crossbuild-essential-${BUILD_ARCHITECTURE} file | |||
| RUN apt-get update && apt-get install -y crossbuild-essential-${BUILD_ARCHITECTURE} file | |||
There was a problem hiding this comment.
If we are just removing the cmake here, which component or where in the pipeline do we install it?
Is there any README.md need to be updated because of this change?
There was a problem hiding this comment.
These are all installed by https://github.com/usdot-fhwa-stol/carma-builds/blob/develop/scripts/install_build_tools.sh. Do you think it would be helpful to mention this explicitly in the README or is the script naming sufficient
There was a problem hiding this comment.
Ah I think that is okay. It maybe beginner question, but looking at the install_build_tools.sh script, I wonder how does installing x86-64 specific cmake work in other architectures?
wget https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}-linux-x86_64.sh
wget https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}-linux-x86_64.tar.gz
chmod u+x cmake-${CMAKE_VERSION}-linux-x86_64.sh
./cmake-${CMAKE_VERSION}-linux-x86_64.sh --skip-license --exclude-subdir --prefix=/usr/local
rm cmake-${CMAKE_VERSION}-linux-x86_64.sh
rm cmake-${CMAKE_VERSION}-linux-x86_64.tar.gz
Do the scripts from cross go and fix/adjust after the x86-64 installation is done to make it cross compilable?
Has it been tested to work for the original issue you were encountering?
There was a problem hiding this comment.
Talked offline about it, looks good to me
paulbourelly999
deleted the
arc-225-fix-arm-focal-cross-compilation-issues
branch
PR Details
Description
Dependent repositories that use carma-builds docker images as CI build environments for compiling and cross-compiling C++ libraries into Debian packages using CPack have had some build issues.
https://github.com/usdot-fhwa-stol/carma-j2735/actions/runs/11601962110/job/32305932330#step:6:788
One difference in build environment between cross-compiled and natively compiled libraries is CMake version. This PR ensures that both cross-compiling and natively compiling build environments install the same build tools
Related GitHub Issue
Related Jira Key
ARC-225
Motivation and Context
Fix cross compilation issues
How Has This Been Tested?
CI
Types of changes
Checklist: