Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble arm compatability #224

Merged
merged 4 commits into from
May 8, 2024
Merged

Humble arm compatability #224

merged 4 commits into from
May 8, 2024

Conversation

afrye51
Copy link
Contributor

@afrye51 afrye51 commented May 6, 2024

PR Details

Description

Added ARM asn1c shared object library, and updated the architecture check in the cmake file to also check for arm vs. x86.

Related GitHub Issue

Related Jira Key

https://usdot-carma.atlassian.net/browse/CF-836

Motivation and Context

Adding ARM and Humble compatability to carma-messenger, for the C1T project

How Has This Been Tested?

Tested building on Humble/ARM, Humble/x86, and Foxy/x86. No actual functionality was tested.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@afrye51 afrye51 requested a review from willjohnsonk May 6, 2024 16:20
@afrye51 afrye51 self-assigned this May 6, 2024
Copy link
Contributor

@willjohnsonk willjohnsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but where does the std_srvs dependency come from?

@afrye51
Copy link
Contributor Author

afrye51 commented May 6, 2024

There was an include for an empty service in the j2735_converter include files, but not that I look at it yeah it can just be removed instead of supported. Not sure why it was there, if there's no usage?

@afrye51 afrye51 merged commit 76b2b74 into develop May 8, 2024
3 checks passed
@afrye51 afrye51 deleted the humble_arm_compatability branch May 8, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants