Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ros2bag launch #243

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix ros2bag launch #243

merged 2 commits into from
Nov 22, 2024

Conversation

adev4a
Copy link
Contributor

@adev4a adev4a commented Nov 22, 2024

PR Details

This PR fixes an issue in the carma-messenger launch script causing the ros2 rosbag recording to error out.
The ThisLaunchFileDir() option being placed after get_package_share_directory calls causes ThisLaunchFileDir() substitution to take the value of the last get_package_share_directory().

In this update the ros2 rosbag record launch option was moved to the start of the script as a workaround.

Additionally the required config directory from the carma-messenger package was added to installation.

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adev4a adev4a requested a review from MishkaMN November 22, 2024 19:48
@adev4a adev4a merged commit 976efa6 into develop Nov 22, 2024
3 checks passed
@adev4a adev4a deleted the fix-ros2bag-launch branch November 22, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants