Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly merge humble #249

Merged
merged 7 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/auto-merge-workflow.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Auto Merge develop to develop-humble

on:
schedule:
- cron: '0 0 * * 1' # Weekly on Monday
workflow_dispatch:

jobs:
call-merge-workflow:
uses: usdot-fhwa-stol/actions/.github/workflows/auto-pr-merge.yml@main
with:
branch_from: develop
branch_to: develop-humble
notify_team: DevOps
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ def generate_launch_description():
description = 'Path of folder on host PC containing route CSV file(s) that can be accessed by plugins'
)

# Launch ROS2 rosbag logging
ros2_rosbag_launch = GroupAction(
actions=[
IncludeLaunchDescription(
PythonLaunchDescriptionSource([ThisLaunchFileDir(), '/ros2_rosbag.launch.py']),
)
]
)

transform_group = GroupAction(
actions=[
PushRosNamespace(EnvironmentVariable('CARMA_TF_NS', default_value='/')),
Expand All @@ -67,7 +76,7 @@ def generate_launch_description():
actions=[
IncludeLaunchDescription(
PythonLaunchDescriptionSource([ThisLaunchFileDir(), '/message.launch.py']),
launch_arguments = {
launch_arguments = {
'configuration_delay' : [configuration_delay]
}.items()
),
Expand All @@ -78,7 +87,7 @@ def generate_launch_description():
actions=[
IncludeLaunchDescription(
PythonLaunchDescriptionSource([ThisLaunchFileDir(), '/plugins.launch.py']),
launch_arguments = {
launch_arguments = {
'configuration_delay' : [configuration_delay],
'route_file_folder' : route_file_folder
}.items()
Expand Down Expand Up @@ -121,6 +130,7 @@ def generate_launch_description():
declare_configuration_delay_arg,
declare_use_rosbag,
declare_route_file_folder,
ros2_rosbag_launch,
transform_group,
v2x_group,
plugins_group,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (C) 2023 LEIDOS.
# Copyright (C) 2024 LEIDOS.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ class TrafficIncidentNode : public carma_ros2_utils::CarmaLifecycleNode
double down_track_;
double up_track_;
double min_gap_;
static constexpr double epsilon_ = 1e-6;
};

} // namespace traffic
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ bool TrafficIncidentNode::stopTrafficBroadcastCallback(
void TrafficIncidentNode::spin_callback(void)
{
if (
traffic_worker_.getDownTrack() > 0 && traffic_worker_.getUpTrack() > 0 &&
traffic_worker_.getMinGap() > 0 && traffic_worker_.getAdvisorySpeed() > 0) {
std::fabs(traffic_worker_.getDownTrack()) > epsilon_ || std::fabs(traffic_worker_.getUpTrack() > epsilon_) || std::fabs(traffic_worker_.getAdvisorySpeed() > epsilon_)) {
// construct local mobilityOperation msg
carma_v2x_msgs::msg::MobilityOperation traffic_mobility_msg =
traffic_worker_.mobilityMessageGenerator(traffic_worker_.getPinPoint());
Expand Down