-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch cooperative perception nodes #2195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma@ubuntu:/$ ros2 topic info outgoing_sdsm Unknown topic 'outgoing_sdsm' carma@ubuntu:/$ ros2 topic info /message/outgoing_sdsm Type: carma_v2x_msgs/msg/SensorDataSharingMessage Publisher count: 1 Subscription count: 1 carma@ubuntu:/$ ros2 topic info /message/outgoing_sdsm --verbose Type: carma_v2x_msgs/msg/SensorDataSharingMessage Publisher count: 1 Node name: cp_external_object_list_to_sdsm_node Node namespace: /environment Topic type: carma_v2x_msgs/msg/SensorDataSharingMessage Endpoint type: PUBLISHER GID: b1.24.10.01.64.ab.c5.0a.0e.8d.3b.95.00.00.b1.03.00.00.00.00.00.00.00.00 QoS profile: Reliability: RMW_QOS_POLICY_RELIABILITY_RELIABLE Durability: RMW_QOS_POLICY_DURABILITY_VOLATILE Lifespan: 9223372036854775807 nanoseconds Deadline: 9223372036854775807 nanoseconds Liveliness: RMW_QOS_POLICY_LIVELINESS_AUTOMATIC Liveliness lease duration: 9223372036854775807 nanoseconds Subscription count: 1 Node name: j2735_convertor_node Node namespace: /message Topic type: carma_v2x_msgs/msg/SensorDataSharingMessage Endpoint type: SUBSCRIPTION GID: e0.41.10.01.48.3b.dd.cf.54.92.c9.60.00.00.cb.04.00.00.00.00.00.00.00.00 QoS profile: Reliability: RMW_QOS_POLICY_RELIABILITY_RELIABLE Durability: RMW_QOS_POLICY_DURABILITY_VOLATILE Lifespan: 9223372036854775807 nanoseconds Deadline: 9223372036854775807 nanoseconds Liveliness: RMW_QOS_POLICY_LIVELINESS_AUTOMATIC Liveliness lease duration: 9223372036854775807 nanoseconds |
carma@ubuntu:/$ ros2 topic info /message/incoming_sdsm --verbose Type: carma_v2x_msgs/msg/SensorDataSharingMessage Publisher count: 1 Node name: j2735_convertor_node Node namespace: /message Topic type: carma_v2x_msgs/msg/SensorDataSharingMessage Endpoint type: PUBLISHER GID: e0.41.10.01.48.3b.dd.cf.54.92.c9.60.00.00.ca.03.00.00.00.00.00.00.00.00 QoS profile: Reliability: RMW_QOS_POLICY_RELIABILITY_RELIABLE Durability: RMW_QOS_POLICY_DURABILITY_VOLATILE Lifespan: 9223372036854775807 nanoseconds Deadline: 9223372036854775807 nanoseconds Liveliness: RMW_QOS_POLICY_LIVELINESS_AUTOMATIC Liveliness lease duration: 9223372036854775807 nanoseconds Subscription count: 1 Node name: cp_sdsm_to_detection_list_node Node namespace: /environment Topic type: carma_v2x_msgs/msg/SensorDataSharingMessage Endpoint type: SUBSCRIPTION GID: b1.24.10.01.64.ab.c5.0a.0e.8d.3b.95.00.00.77.04.00.00.00.00.00.00.00.00 QoS profile: Reliability: RMW_QOS_POLICY_RELIABILITY_RELIABLE Durability: RMW_QOS_POLICY_DURABILITY_VOLATILE Lifespan: 9223372036854775807 nanoseconds Deadline: 9223372036854775807 nanoseconds Liveliness: RMW_QOS_POLICY_LIVELINESS_AUTOMATIC Liveliness lease duration: 9223372036854775807 nanoseconds |
carma@ubuntu:/$ ros2 topic info /environment/fused_external_objects --verbose Type: carma_perception_msgs/msg/ExternalObjectList Publisher count: 1 Node name: cp_track_list_to_external_object_list_node Node namespace: /environment Topic type: carma_perception_msgs/msg/ExternalObjectList Endpoint type: PUBLISHER GID: b1.24.10.01.64.ab.c5.0a.0e.8d.3b.95.00.00.bb.03.00.00.00.00.00.00.00.00 QoS profile: Reliability: RMW_QOS_POLICY_RELIABILITY_RELIABLE Durability: RMW_QOS_POLICY_DURABILITY_VOLATILE Lifespan: 9223372036854775807 nanoseconds Deadline: 9223372036854775807 nanoseconds Liveliness: RMW_QOS_POLICY_LIVELINESS_AUTOMATIC Liveliness lease duration: 9223372036854775807 nanoseconds Subscription count: 1 Node name: motion_computation_node Node namespace: /environment Topic type: carma_perception_msgs/msg/ExternalObjectList Endpoint type: SUBSCRIPTION GID: 66.06.10.01.3f.75.09.ad.b2.1a.52.94.00.00.da.04.00.00.00.00.00.00.00.00 QoS profile: Reliability: RMW_QOS_POLICY_RELIABILITY_RELIABLE Durability: RMW_QOS_POLICY_DURABILITY_VOLATILE Lifespan: 9223372036854775807 nanoseconds Deadline: 9223372036854775807 nanoseconds Liveliness: RMW_QOS_POLICY_LIVELINESS_AUTOMATIC Liveliness lease duration: 9223372036854775807 nanoseconds |
adamlm
suggested changes
Nov 21, 2023
carma/launch/environment.launch.py
Outdated
Comment on lines
93
to
94
carma_cooperative_perception_param_file = os.path.join( | ||
get_package_share_directory('carma_cooperative_perception'), 'config/params.yaml') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recommended way to do paths now is with pathlib
. This should be refactored to something like this:
carma_cooperative_perception_param_file = str(get_package_share_directory("carma_cooperative_perception") / "config/params.yaml")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imported pathlib to handle this
adamlm
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR launches the cp nodes in carma-platform and connects the topics. Resulting nodes and topic connections look as follows, now:
Related GitHub Issue
#2185
Related Jira Key
CDAR-449
Motivation and Context
How Has This Been Tested?
Local integration tested with develop-development images
Types of changes
Checklist: