Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ROSBag 2 order of launch #2482

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Change ROSBag 2 order of launch #2482

merged 4 commits into from
Jan 22, 2025

Conversation

MishkaMN
Copy link
Contributor

PR Details

Description

This PR makes the ROSBag2 and ros2_trace to start first as they need to record everything.

Related GitHub Issue

NA

Related Jira Key

ARC-264

Motivation and Context

Fixing ROSBAG2 recording issue and found this optimization opportunity

How Has This Been Tested?

Tested on Blue Lexus

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from adev4a January 17, 2025 19:03
@MishkaMN MishkaMN self-assigned this Jan 17, 2025
@MishkaMN MishkaMN added the enhancement New feature or request label Jan 17, 2025
@MishkaMN
Copy link
Contributor Author

waiting to merge this after carma-base PR is merged usdot-fhwa-stol/carma-base#232

@MishkaMN MishkaMN merged commit bb6ab96 into develop Jan 22, 2025
2 of 3 checks passed
@MishkaMN MishkaMN deleted the feature/lexus-latest-mish branch January 22, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants