-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyBind to bind CarmaClock to Python Module #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbourelly999
requested review from
MishkaMN,
kjrush,
willjohnsonk and
dan-du-car
May 24, 2024 13:52
dan-du-car
reviewed
May 24, 2024
bindings based on build architecture
dan-du-car
reviewed
May 28, 2024
dan-du-car
reviewed
May 28, 2024
Quality Gate passedIssues Measures |
dan-du-car
approved these changes
May 28, 2024
kjrush
approved these changes
May 28, 2024
paulbourelly999
added a commit
that referenced
this pull request
May 28, 2024
9 tasks
paulbourelly999
added a commit
that referenced
this pull request
May 28, 2024
* Update sonar-scanner workflow to target main branch * Undo #24 unintentional change
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This Pull Request adds functionality to create python module bindings for the existing C++ CARMA Time Library. It does this using PyBind11, a light weight, header only library.
Unfortunately do to limitation encounters with downloading and including Python3 for cross-compile targets (armhf, arm32, and arm64) I was only able to get the python module binding to work for native builds (x64). To account for this the, all the python module binding occurs conditionally based on an environment variable
BUILD_ARCHICTECTURE
set in carma-builds for cross compile targets (https://github.com/usdot-fhwa-stol/carma-builds/blob/a77b21967f06c3a8b66c060f8ed4f1e138b7159f/Dockerfile#L25)Important
The changes included here will build python module bindings for all native builds and the generated debian package should include the shared library with these bindings. For cross-compile targets, it will simply skip this process and compile just the C++ library since I ran into many issues trying to correctly include dependencies like python3 for cross-compile targets.
Related GitHub Issue
Related Jira Key
TT-69
Motivation and Context
How Has This Been Tested?
test_carma_clock_python_module_binding CMake target
Types of changes
Checklist: