Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of official ROSBag2 fix for silently stopping subscription #3

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

MishkaMN
Copy link

@MishkaMN MishkaMN commented Jan 15, 2025

PR Details

Description

There was an issue on Lexus when if the next topic's message type is not available, rosbag2 would not continue recording new topics, and get stuck. This was actually reported and fixed on the main repos, but not available in foxy.
This PR is making it available so we can support ongoing data analysis although it wont be needed in the future when we move to humble
Porting change to fix the silent subscriber issue:
https://github.com/ros2/rosbag2/pull/848/files

Related GitHub Issue

NA

Related Jira Key

ARC-264

Motivation and Context

Lexus was not recording all the topics. It has random topics, but those "registered" is recorded fine.

How Has This Been Tested?

Used local containers and publishes topics with and without message type available and see it continues accepting new topics
Also tested on Lexus with this new branch and consistently record all the topics now including osm map:
image

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from adev4a January 15, 2025 19:22
@MishkaMN MishkaMN self-assigned this Jan 15, 2025
@MishkaMN MishkaMN added the bug Something isn't working label Jan 15, 2025
@MishkaMN MishkaMN requested a review from saina-ramyar January 16, 2025 14:08
@adev4a
Copy link

adev4a commented Jan 16, 2025

Looks good to me. Can we just update the PR title to indicate this is a backport of changes in the official rosbag2 repo?

@MishkaMN MishkaMN changed the title Arc 264 sub silent stop Backport of official ROSBag2 fix for silently stopping subscription Jan 17, 2025
@MishkaMN MishkaMN merged commit 58c23b8 into foxy-future Jan 17, 2025
@MishkaMN MishkaMN deleted the arc-264-sub-silent-stop branch January 17, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants