Backport of official ROSBag2 fix for silently stopping subscription #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
There was an issue on Lexus when if the next topic's message type is not available, rosbag2 would not continue recording new topics, and get stuck. This was actually reported and fixed on the main repos, but not available in foxy.
This PR is making it available so we can support ongoing data analysis although it wont be needed in the future when we move to humble
Porting change to fix the silent subscriber issue:
https://github.com/ros2/rosbag2/pull/848/files
Related GitHub Issue
NA
Related Jira Key
ARC-264
Motivation and Context
Lexus was not recording all the topics. It has random topics, but those "registered" is recorded fine.
How Has This Been Tested?
Used local containers and publishes topics with and without message type available and see it continues accepting new topics
Also tested on Lexus with this new branch and consistently record all the topics now including osm map:
Types of changes
Checklist: