Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#BRU-18) : "inherit" auth mode for inheriting auth to requests from collection #1667

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

lohxt1
Copy link
Collaborator

@lohxt1 lohxt1 commented Feb 26, 2024

Inherit auth to requests from collection

inherit_auth_mode.webm
inherit_auth_mode_cli.webm

@lohxt1 lohxt1 changed the title feature - "inherit" auth mode for inheriting auth to requests from collection feature/BRU-18 - "inherit" auth mode for inheriting auth to requests from collection Feb 26, 2024
@lohxt1 lohxt1 changed the title feature/BRU-18 - "inherit" auth mode for inheriting auth to requests from collection feat(#BRU-18) : "inherit" auth mode for inheriting auth to requests from collection Feb 26, 2024
@helloanoop helloanoop merged commit 7c416a9 into usebruno:main Feb 26, 2024
0 of 3 checks passed
@helloanoop
Copy link
Contributor

Merged!

Thanks for taking care of this @lohxt1 !

@helloanoop
Copy link
Contributor

@lohxt1 Just a FYI, I have made changes to gracefully handle older collections which are using none and still inherit collection auth.

Plan is to give some time to for users to migrate (and broadcast these via x/discord/communit calls) before causing CI pipelines to break.

See 1cf8a2f

@lohit-bruno
Copy link
Collaborator

Got it @helloanoop

@timwsuqld
Copy link

@helloanoop is there a way to make none actually None? I want to be able to use inherit, but have a route that needs to not inherit.

@Tydax
Copy link

Tydax commented Apr 9, 2024

@helloanoop is there a way to make none actually None? I want to be able to use inherit, but have a route that needs to not inherit.

EDIT: Nevermind, this seems to be on purpose to keep a retro compatible behaviour

I can confirm that I have the same issue, it seems that No auth on a request does not “override” the collection authentication setting and defaults to an inherit behaviour. I think this is a bug.

For now, I got it working by manually defining an Authorization header in the Headers tab in the collection's settings and then adding another Authorization header with a blank value on the request that should not use it.

helloanoop added a commit that referenced this pull request Apr 29, 2024
@helloanoop
Copy link
Contributor

Breaking change will be shipped in v1.16.0
After which None means None

@melroy89
Copy link

Two tests are failing tho..?

@slowjoe007
Copy link
Contributor

Also figured this in #2057. The tests appear to fail due to this change when executed via bru CLI. The request auth/inherit auth is working inside the GUI though.

@melroy89
Copy link

melroy89 commented May 1, 2024

I don't understand why a failing CICD run was merged, causing regression. But yea.

pietrygamat added a commit to pietrygamat/bruno that referenced this pull request May 5, 2024
end3rbyte pushed a commit to end3rbyte/bruno that referenced this pull request May 6, 2024
helloanoop pushed a commit that referenced this pull request May 6, 2024
jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants