Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interactive_pampa.xml #168

Open
wants to merge 60 commits into
base: release_23.0_europe
Choose a base branch
from

Conversation

yvanlebras
Copy link

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

gmauro and others added 30 commits May 20, 2023 16:05
Until the release notes are out.
* Add DIVAnd interactive tool

* Update interactivetool_divand.xml

---------

Co-authored-by: Björn Grüning <[email protected]>
… into two parts: the visualization plugin and backend changes. The client code integrates the h5web visualizer into Galaxy (https://h5web.panosc.eu). The backend changes add the ability to access the contents of a dataset without needing to read the whole dataset, which is essential for large files. It is based on the h5grove API (https://github.com/silx-kit/h5grove).
<tool id="interactive_tool_pampa" tool_type="interactive" name="pampa" version="0.0.1" profile="22.01">
<description>Performance Indicators of Marine Protected Areas for the management of coastal ecosystems, resources and their uses</description>
<requirements>
<container type="docker">ylebras/pampa:latest</container>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always remember to version those images when you bring them in production, ideally in sync with the tool version.

@yvanlebras
Copy link
Author

Ok, I tested it on a local Galaxy instance. It seems to work well!!!

image

@yvanlebras
Copy link
Author

Ok, tested, and it seems ok on my side now! The app is launched and work. Need to look at it more deeply to see if there is app dedicated errors using it with real data AND look to ameliorate data format (tabular instead csv) and links with inputs and outputs

@yvanlebras
Copy link
Author

hmmm .Stooping the GxIT, just see that ouput datasets, are not synchronized with Galaxy... duno why

@yvanlebras
Copy link
Author

yvanlebras commented Jun 10, 2023

the same with last version. But output datasets are now on the good PATH, '{Galaxy working dir}/Results' as seen here :

root@87a0b7f9057e:/home/ylebras/GxIT/galaxy/database/jobs_directory/000/164/working# ls
Results
root@87a0b7f9057e:/home/ylebras/GxIT/galaxy/database/jobs_directory/000/164/working# ls Results
MoyenneAnneeVisiteSite.csv       TableEspeces.csv                        UnitobsMetriques.csv
NombreSiteAnnee.csv              UnitobsEspeceClassetailleMetriques.csv
PlanEchantillonnage_basique.csv  UnitobsEspeceMetriques.csv
root@87a0b7f9057e:/home/ylebras/GxIT/galaxy/database/jobs_directory/000/164/working#

Any idea ?

For information, here is the Galaxy xml outputs tag:

    <outputs>
        <data name="moy" from_work_dir="Results/MoyenneAnneeVisiteSite.csv" format="csv" />
		<data name="nbre" from_work_dir="Results/NombreSiteAnnee.csv" format="csv" />
		<data name="plan" from_work_dir="Results/PlanEchantillonnage_basique.csv" format="csv" />
		<data name="table" from_work_dir="Results/TableEspeces.csv" format="csv" />
		<data name="mettaille" from_work_dir="Results/UnitobsEspeceClassetailleMetriques.csv" format="csv" />
		<data name="metsp" from_work_dir="Results/UnitobsEspeceMetriques.csv" format="csv" />
		<data name="metunitobs" from_work_dir="Results/UnitobsMetriques.csv" format="csv" />
    </outputs>

@@ -0,0 +1,55 @@
<tool id="interactive_tool_pampa" tool_type="interactive" name="pampa" version="0.0.1" profile="22.01">
<description>Performance Indicators of Marine Protected Areas for the management of coastal ecosystems, resources and their uses</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too long for my taste

ln -s /srv/shiny-server/sample-apps/PAMPA/Results . &&
mkdir Results &&
mkdir /srv/shiny-server/sample-apps/PAMPA/Results/ &&
ln -s Results /srv/shiny-server/sample-apps/PAMPA/Results/ &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this working? folder "Results" exist already as you do mkdir before

@bgruening bgruening force-pushed the release_23.0_europe branch from e19ba2e to 01e4d19 Compare June 28, 2023 19:54
@bgruening bgruening force-pushed the release_23.0_europe branch from 613623e to 7eab9d9 Compare July 26, 2023 08:40
@bgruening
Copy link
Member

This needs a rebase and retarget to the release_24.0_europe branch.

@yvanlebras
Copy link
Author

Thank you Björn! Will look at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.