This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
SD-107645 | Products ingesting incorrectly #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Snap V3 CAPI] use pixel id for offline events * fix test * Add default value for item_category --------- Co-authored-by: David Bordoley <[email protected]>
segmentio#1926) * Moves ad account and campaign fields from regular field section to hook field section * When creating or updating or getting conversion rule, pull from hookInputs.adAccountId rather than the payload * Associate conversion as a part of the conversion creation or update rather than as a part of streaming an event * Updates api unit tests * Removes campaign conversion related unit test from streamConversion tests * removes stray tab from linkedin description * Updates snapshots * Removes timestamps from snapshot since they are flaky * core: Allows hook input fields to be arrays of values * Moves campaign association to after the conversion rule is created or updated * Uses a setter method to set the conversion rule id in the linkedin client rather than setting it in the constructor. This is cleaner since we need the client to create the ID and so don't know what that ID will be yet until it is created * Allows hookInputs to be passed in the data object to the dynamic field executor * Removes tuple return from parseIdFromUrn(), error will be returned if that method returnd undefined instead
segmentio#1936) * external_id is only shown if role is not lead * Adds dependsOn to new LinkedIn fields * Revert "external_id is only shown if role is not lead" This reverts commit 5468155. * Google Enhanced Conversions: Only show restatement_value/currency_code if attribution type is not RETRACTION
* Add mantle action destination * Add defaults and description for mantle destination
…egmentio#1934) * fix: partially formatted E164 numbers failing to send * chore: change test numbers * chore: added more tests around external id
* update to track event to use event capture * update to identify call and fields * update to identify test * update to test suite
* timeout error 429 and stringify * Updated stringify setting * fixed recipient spelling * refactor * removed console log statement * adding stats context * removing bad validation --------- Co-authored-by: Joe Ayoub <[email protected]>
Registering new Integrations
- @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected]
* Try new release tag * fix npm package format * Rename steps * use context params * Refactor and simplify code * minor fixes and cleanup * count publish commits only for release * refactor * cosmetic changes * exclude scripts from tsconfig and eslint
* Adds an else statement to fix an issue were conversion rules were always created and never updated * Removes the userIds array field in favor of separate individual fields which an array will be constructed out of. Also hashes user email before sending * Removes manually thrown error when first or last name are not provided for userInfo object, since AJV throws that error for us * updates streamConversion unit tests * Adds another unit test, it's not passing yet but it will, one day * Updates snapshot tests and snapshots * Deletes snapshot unit tests that were just a copy of existing snapshot unit tests, and therefore redundant * Fixes expected nock body * Passes userIds array correctly, with idType and idValue params rather than type and value * Updates unit tests to use idType and idValue instead
* Bootstrap sendTrack action * Add timestamp * Add datadog stat * Add description * add missing engage_space property * minor fixes
* updates to Kafka * updates to kafka * minor change * updating tests * removing bad reference * removing partitioner setting field
Co-authored-by: David Bordoley <[email protected]>
- @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected]
…n??? (segmentio#1961) Co-authored-by: Nick Aguilar <[email protected]>
* Provides some simple defaults for streamConversion. Adds unit tests. Adds to defaults section on README * Hardcodes a messageID in test event and tests default mappings with it * Fixes broken hyperengage unit test which broke for some unknown reason???
* Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Use from-package workflow instead of from-git * Comment out the release script
* adding logging * removing logging * refactor * making some fields visible
…g Audien…" (segmentio#2129) This reverts commit a76c78d.
* empty commit * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected]
* adding arrayeditor option * update description
- @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected]
rbcetin
approved these changes
Jul 8, 2024
* Introduce new release flow * quick check to validate push permissios * revert changes * refactor release.sh * revert release.sh * Revert unwanted changes * Restore gh pat token change
…egmentio#2081) * added depends_on conditions on salesforce actions * updated conditions for depends_on fields * Updated depends on condition for delete operation in salesforce actions * Updated depends on conditions for salesforce actions Contact, lead, opportunity * Added depends on for cases action in salesforce
We needed to send a few other fields from the context to make our app more robust.
* Add platform name * Set platformName optional, and use platformId as a default value
* updated the mapping * update delete object * added comments * fixed the mapping
* initial commit * fix failing tests * updated saveUser action * updated saveOrder action * updated saveEvent action * added action descriptions * updated presets * flattened saveEvent mapping * fixed saveEvent.perform * fixed saveEvent mapping * updated snapshots * updated snapshots * fixed saveEvent payload structure * don't include empty objects in payload * updated * progress * restructure events * remove defaults for optional fields * restore address field * update untranslated title default values * updated snapshots * remove unused import * fixed default paths * reorganized saveUser fields * updated saveBaseEvent fields * fixed default_address default in saveUser * moved custom event name to saveBaseEvent * updated tests * added defaults for customer field in saveEvent * test commit * refactor fields * consistent naming for fields variables * removed cartFields from saveCartEvent * removed less important saveOrder fields * updated event names * moved event name field from common fields * fixed field name * refactor event fields * updated generated types * updated tests * fixed checkout fields * updated payload transformation functions * removed custom event preset * fixed identifiers transformation * updated tests * wrapped cart and checkout fields into objects * updated tests * minor changes to presets --------- Co-authored-by: Victor Ruban <[email protected]> Co-authored-by: Joe Ayoub <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.