SD-107645 | Products ingesting incorrectly

.eslintrc.js

@@ -1,6 +1,6 @@
 module.exports = {
   root: true,
-  ignorePatterns: ['node_modules', 'dist', 'templates', '**/node_modules'],
+  ignorePatterns: ['node_modules', 'dist', 'templates', 'scripts', '**/node_modules'],
   parser: '@typescript-eslint/parser',
   parserOptions: {
     ecmaVersion: 2019,

.github/CODEOWNERS

@@ -6,32 +6,32 @@
 
 # Actions common lib folder
 
-actions-shared/ @segmentio/build-experience-team
+actions-shared/ @segmentio/build-experience-team @segmentio/strategic-connections-team
 
 # AJV utils
 
-ajv-human-errors/ @segmentio/build-experience-team
+ajv-human-errors/ @segmentio/build-experience-team @segmentio/strategic-connections-team
 
 # Browser destinations
 
 browser-destinations/ @segmentio/libraries-web-team @segmentio/strategic-connections-team @segmentio/build-experience-team
 
 # CLI private libs
 
-cli-internal/ @segmentio/build-experience-team
+cli-internal/ @segmentio/build-experience-team @segmentio/strategic-connections-team
 
 # CLI binary
 
-cli/ @segmentio/build-experience-team
+cli/ @segmentio/build-experience-team @segmentio/strategic-connections-team
 
 # Core actions runtime
 
-core/ @segmentio/build-experience-team
+core/ @segmentio/build-experience-team @segmentio/strategic-connections-team
 
 # Destination definitions and their actions
 
 destination-actions/ @segmentio/strategic-connections-team @segmentio/build-experience-team
 
 # Utilities for event payload validation against an action's subscription AST.
 
-destination-subscriptions/ @segmentio/build-experience-team
+destination-subscriptions/ @segmentio/build-experience-team @segmentio/strategic-connections-team

.github/workflows/ci.yml

@@ -17,13 +17,13 @@ jobs:
 
     steps:
       # See nx recipe: https://nx.dev/recipes/ci/monorepo-ci-github-actions
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
           fetch-depth: 0 # nx recipe
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: 'https://registry.npmjs.org'
@@ -54,13 +54,13 @@ jobs:
         node-version: [18.x]
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
           fetch-depth: 0 # nx recipe
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: 'https://registry.npmjs.org'
@@ -93,13 +93,13 @@ jobs:
         node-version: [18.x]
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
           fetch-depth: 0 # nx recipe
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: 'https://registry.npmjs.org'
@@ -145,12 +145,12 @@ jobs:
         node-version: [18.x]
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: 'https://registry.npmjs.org'
@@ -167,6 +167,9 @@ jobs:
       - name: Build
         run: NODE_ENV=production yarn build:browser-bundles
 
+      - name: Size Limit
+        run: yarn browser size
+
       # - name: Run Saucelabs Tests
       #   working-directory: packages/browser-destinations-integration-tests
       #   shell: bash

.github/workflows/ext.yml

@@ -17,8 +17,8 @@ jobs:
         node-version: [18.x]
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: yarn

.github/workflows/label-prs.yml

@@ -0,0 +1,62 @@
+# This workflow labels PRs based on the files that were changed. It uses a custom script to this
+# instead of actions/labeler as few of the tags are more than just file changes.
+
+name: Label PRs
+on:
+  pull_request_target:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  pr-labeler:
+    runs-on: ubuntu-20.04
+    permissions:
+      contents: read
+      pull-requests: write
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - name: Compute Labels
+        id: compute-labels
+        uses: actions/github-script@v7
+        with:
+          # Required for the script to access team membership information.
+          # Scope: members:read and contentes:read permission on the organization.
+          github-token: ${{ secrets.GH_PAT_MEMBER_AND_PULL_REQUEST_READONLY }}
+          script: |
+            const script = require('./scripts/github-action/compute-labels.js')
+            await script({github, context, core})
+      # Separating apply labels to separate step to avoid using PAT token auth.
+      - name: Apply Labels
+        uses: actions/github-script@v7
+        env:
+          labelsToAdd: '${{ steps.compute-labels.outputs.add }}'
+          labelsToRemove: '${{ steps.compute-labels.outputs.remove }}'
+        with:
+          script: |
+            const { labelsToAdd, labelsToRemove, DRY_RUN } = process.env
+            if(Boolean(DRY_RUN)){
+              core.info(`Would have added labels: ${labelsToAdd}`)
+              core.info(`Would have removed labels: ${labelsToRemove}`)
+              return
+            }
+            if(labelsToAdd.length > 0) {
+              await github.rest.issues.addLabels({
+                issue_number: context.payload.pull_request.number,
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                labels: labelsToAdd.split(',')
+              });
+            }
+            if(labelsToRemove.length > 0) {
+              const requests = labelsToRemove.split(',').map(label => {
+                return github.rest.issues.removeLabel({
+                  issue_number: context.payload.pull_request.number,
+                  name: label,
+                  owner: context.repo.owner,
+                  repo: context.repo.repo
+                });
+              });
+              await Promise.all(requests);
+            }

.github/workflows/publish.yml

@@ -7,6 +7,7 @@ on:
   push:
     branches:
       - main
+      - release
 
 jobs:
   build-and-publish:
@@ -22,12 +23,12 @@ jobs:
         node-version: [18.x]
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           token: ${{ secrets.GH_PAT }}
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: 'https://registry.npmjs.org'
@@ -55,4 +56,29 @@ jobs:
 
       - name: Publish
         run: |
-          yarn lerna publish from-git --yes --allowBranch=main --loglevel=verbose --dist-tag latest
+          yarn lerna publish from-package --yes --allowBranch=main --loglevel=verbose --dist-tag latest
+
+  release:
+    needs: build-and-publish # comment when testing locally with https://github.com/nektos/act
+
+    runs-on: ubuntu-20.04
+    timeout-minutes: 15
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0 # Shallow clones should be disabled to ensure the commit history for the repository is available to the action
+          fetch-tags: true
+
+      - name: Generate Release Tag
+        id: get-release-tag
+        run: ./scripts/generate-release-tags.sh
+
+      - name: Create Github Release
+        id: create-github-release
+        uses: actions/github-script@v7
+        env:
+          RELEASE_TAG: ${{ steps.get-release-tag.outputs.release-tag }}
+        with:
+          script: |
+            const script = require('./scripts/github-action/create-github-release.js')
+            await script({github, context, core, exec})

.github/workflows/version-packages.yml

@@ -0,0 +1,72 @@
+# This workflow is triggered manually via the GitHub Actions page or API
+name: Version Packages
+on:
+  workflow_dispatch:
+    inputs:
+      branch:
+        description: 'Branch to create PR from'
+        required: true
+        default: 'release-actions'
+
+jobs:
+  build-and-version-packages:
+    env:
+      HUSKY: 0
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+      contents: write
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: main
+          depth: 0
+
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          registry-url: 'https://registry.npmjs.org'
+          cache: yarn
+
+      - name: Checkout branch
+        run: |
+          git checkout -b ${{ github.event.inputs.branch }}
+          git push origin ${{ github.event.inputs.branch }}
+
+      - name: Install Dependencies
+        run: yarn install --frozen-lockfile --ignore-optional
+
+      - name: Configure git
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
+
+      - name: Build
+        run: NODE_ENV=production yarn build
+
+      - name: Version Packages
+        run: yarn lerna version minor --allow-branch ${{ github.event.inputs.branch }} --no-git-tag-version --no-commit-hooks --no-private --yes
+
+      - name: Commit and push
+        id: commit_and_push
+        run: |
+          count=$(git diff --cached --stat)
+          if [ -z "$count" ]; then
+            echo "No changes to commit"
+            echo "SKIP_PR=true" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+          git add .
+          git commit -m "chore: version packages"
+          git push origin ${{ github.event.inputs.branch }}
+
+      - name: Create PR
+        if: ${{ steps.commit_and_push.outputs.SKIP_PR != 'true' }}
+        run: |
+          packages_published=$(git status -s -uno| grep "package.json" |awk '{print $2}'| xargs jq -r '.name + "@" + .version' --argjson null {})
+          pr_message="This PR was opened by GithHub Actions. Whenever you're ready to publish the packages, merge this PR."
+          description="$(printf "%s\n # Packages\n%s" "$pr_message" "$packages_published")"
+          gh pr create --base main --head ${{ github.event.inputs.branch }} --title "Publish" --body "$description"
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

CONTRIBUTING.md

@@ -50,7 +50,7 @@ Before continuing, please make sure to read our [Code of Conduct](./CODE_OF_COND
    - For cloud-mode destinations, follow these instructions: [Build & Test Cloud Destinations](./docs/testing.md).
    - If you are building a device-mode destination, see the [browser-destinations README](./packages/browser-destinations/README.md).
 
-4. When you have questions, ask in the Segment Partners Slack workspace - use the **#dev-center-pilot** channel.
+4. When you have questions, reach out to [email protected] for assistance.
 
 ## Submit a pull request