Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Planning #32

Merged
merged 38 commits into from
Feb 18, 2018
Merged

Path Planning #32

merged 38 commits into from
Feb 18, 2018

Conversation

amessing
Copy link
Member

@amessing amessing commented Feb 7, 2018

No description provided.

@amessing amessing added this to the RIP v0.1 milestone Feb 7, 2018
@jptech
Copy link
Member

jptech commented Feb 7, 2018

Resolves #17

@robobenklein
Copy link
Member

@robobenklein will take a look into the docker or system library caching for travis about this library dependency soon.

Andrew Messing added 2 commits February 12, 2018 10:54
@@ -1,3 +1,5 @@
#!/usr/bin/env bash

cd external/g2o
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to keep directory locations in check, we should use pushd and popd to build a directory stack and then return to the original directory.

pushd external/g2o
#stuff
popd
# back at location

Copy link
Member

@jptech jptech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If it fits, it ships." Travis is now passing, so I am approving the merger. Future work can be included in a new PR.

@jptech jptech merged commit 42fd1d0 into dev Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants