-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIP v0.2 (to master) #74
Open
jptech
wants to merge
281
commits into
dev
Choose a base branch
from
integration/rip-v0.2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o navigation/dev nav/dev -> nav/dev
…017/rip into navigation/parker
Added string_literal type and prefix/suffix attributes to argument.
…7/rip into navigation/parker
…into navigation/localization
…7/rip into navigation/parker
…7/rip into navigation/parker
…a configurable threshold
jptech
requested review from
amessing,
robobenklein,
xxAtrain223 and
argvrutter
April 15, 2018 20:59
Codecov Report
@@ Coverage Diff @@
## dev #74 +/- ##
==========================================
+ Coverage 91.68% 94.26% +2.58%
==========================================
Files 70 45 -25
Lines 4364 2283 -2081
==========================================
- Hits 4001 2152 -1849
+ Misses 363 131 -232
Continue to review full report at Codecov.
|
…into navigation/localization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go ahead & get this stuff into integration straight to master for RIP v0.2. Most of this seems to work in practice.