Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VO:0005505 - vaccine for platform #623

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Sep 24, 2023

Part of #619.

Similarly to #620, this adds a mid-level grouping term between VO:0000001 (vaccine) and several children representing vaccine platforms:

  1. conjugate vaccine
  2. DNA vaccine
  3. inactivated vaccine
  4. live virulent vaccine
  5. live attenuated vaccine
  6. passive vaccine
  7. toxoid vaccine
  8. whole organism vaccine
  9. virus-like particle vaccine
  10. recombinant vector vaccine
  11. RNA vaccine
  12. subunit vaccine

This is added in the term "vaccine for platform" (VO:0005505). This doesn't add any axiomization regarding this grouping at the moment, since it's not yet clear if there's a shared way of ontologizing "what is a platform". Looking forward, platforms are typically defined as a combination of the one or more of the components/antigens/adjuvants/other ingredient types

Note: this PR is fully independent of #622

Similarly to vaccineontology#620, this adds a mid-level grouping term between VO:0000001 (vaccine) and several children representing vaccine platforms:

1. conjugate vaccine
2. DNA vaccine
3. inactivated vaccine
4. live virulent vaccine
5. live attenuated vaccine
6. passive vaccine
7. toxoid vaccine
8. whole organism vaccine
9. virus-like particle vaccine
10. recombinant vector vaccine
11. RNA vaccine
12. subunit vaccine

This is added in the term "vaccine for platform" (VO:0005505). This doesn't add any axiomization regarding this grouping at the moment, since it's not yet clear if there's a shared way of ontologizing "what is a platform". Looking forward, platforms are typically defined as a combination of the one or more of the components/antigens/adjuvants/other ingredient types
@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 24, 2023

cc @yongqunh @Huffmaar

@Huffmaar
Copy link
Contributor

Huffmaar commented Sep 24, 2023 via email

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 25, 2023

Hi @Huffmaar, thanks for the feedback.

  1. I think this is okay, since you could make subclasses that use both of those as mixins
  2. I don't think that combining multiple vaccines together constitutes as a platform itself - the platform is more about the combination of ingredients that make up a single one. There might also be a different BFO branch under which vaccine cocktails should go that's different from vaccines at all
  3. A lot of recent literature uses the phrase "vaccine platform" (a few examples: https://ncirs.org.au/vaccine-platforms, https://www.belfercenter.org/publication/technology-factsheet-vaccine-platforms, https://www.sciencedirect.com/science/article/pii/S2001037021001732). I think it means the same thing as what you are saying - barring that Illumina also uses "platform" to mean something different in their domain. If you don't like "vaccine for platform" as a term, I am happy to also change this to "vaccine by type" or something else
  4. Does this mean you want me to add that as a top-level axiom for the "vaccine for platform" term?

@Huffmaar
Copy link
Contributor

Huffmaar commented Oct 3, 2023

  1. Then it should be fine.
  2. Alright, in that case. I would ask add a synonym; 'vaccine by platform type'.
  3. That is my current preference, but want to confer with @yongqunh before committing. If need be, there are specific children of 'vaccine role' that can be added. 'live attenuated vaccine' and 'inactivated vaccine' would not have a role, but inherit 'whole vaccine role' from 'whole vaccine'.

I'm still worried about 2 and it showing up due to shared inheritances (i.e. which one would be primary when we add new vaccines). Especially as cocktail vaccines can either share the same platform, or differ (usually as part of prime-boost vaccines). But other than that, I don't have any further issues.

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 15, 2023

hi @Huffmaar, I updated the name based on your suggestion and rebased on the main branch.

If I were encoding a cocktail vaccine, I would make relations that it has a component with multiple other vaccines, each of which can have the platforms annotated on them as subclasses directly

@Huffmaar
Copy link
Contributor

Huffmaar commented Nov 15, 2023 via email

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 15, 2023

I think the discussion about the components should be separated from this PR, but vo:0000520 might work

@zhengj2007 zhengj2007 merged commit 96425bb into vaccineontology:master Nov 16, 2023
@cthoyt cthoyt deleted the platforms branch November 16, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants