Fix empty response for ACL CAT category subcommand for module defined categories #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roshan Khatri <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1140 +/- ##
=========================================
Coverage 70.65% 70.65%
=========================================
Files 114 114
Lines 61718 61717 -1
=========================================
+ Hits 43606 43607 +1
+ Misses 18112 18110 -2
|
hpatro
reviewed
Oct 9, 2024
|
We can update the title to "Fix empty response for ACL CAT category subcommand for module defined categories" |
roshkhatri
changed the title
Co-authored-by: Harkrishn Patro <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
hpatro
approved these changes
Oct 9, 2024
enjoy-binbin
approved these changes
Oct 10, 2024
enjoy-binbin
added
the
release-notes
madolson
approved these changes
Oct 10, 2024
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Oct 10, 2024
… categories (valkey-io#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]> Signed-off-by: naglera <[email protected]>
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this pull request
Oct 20, 2024
… categories (valkey-io#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]>
roshkhatri
added a commit
to roshkhatri/valkey
that referenced
this pull request
Dec 9, 2024
… categories (valkey-io#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Jan 6, 2025
… categories (valkey-io#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]>
|
Removing from 7.2 backport as defining ACL categories via module isn't supported in 7.2 #1413 |
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Jan 7, 2025
… categories (valkey-io#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Jan 7, 2025
… categories (#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]>
roshkhatri
added a commit
to roshkhatri/valkey
that referenced
this pull request
Feb 11, 2025
… categories (valkey-io#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module commands which were added to acl categories were getting skipped when
ACL CAT categorycommand was executed.This PR fixes the bug.
Before:
After: