[Backporting]Fix empty response for ACL CAT category subcommand for module defined… #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… categories (valkey-io#1140) The module commands which were added to acl categories were getting skipped when `ACL CAT category` command was executed. This PR fixes the bug. Before: ``` 127.0.0.1:6379> ACL CAT foocategory (empty array) ``` After: ``` 127.0.0.1:6379> ACL CAT foocategory aclcheck.module.command.test.add.new.aclcategories ``` --------- Signed-off-by: Roshan Khatri <[email protected]> Co-authored-by: Harkrishn Patro <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
hpatro
reviewed
Dec 13, 2024
Comment on lines
+134
to
+146
| test {test if foocategory acl categories is added} { | ||
| r acl SETUSER j8 on >password -@all +@foocategory | ||
| assert_equal [r acl DRYRUN j8 aclcheck.module.command.test.add.new.aclcategories] OK | ||
| } | ||
|
|
||
| test {test if ACL CAT output for the new category is correct} { | ||
| assert_equal [r ACL CAT foocategory] aclcheck.module.command.test.add.new.aclcategories | ||
| } | ||
|
|
||
| test {test permission compaction and simplification for categories added by a module} { | ||
| r acl SETUSER j9 on >password -@all +@foocategory -@foocategory | ||
| catch {r ACL GETUSER j9} res | ||
| assert_equal {-@all -@foocategory} [lindex $res 5] |
There was a problem hiding this comment.
All these tests aren't part of the unstable merge changes? I don't think we should get change beyond the scope of the commit 9b8a061.
|
I think this was a mistake to backport - we will not be able to backport this as we do not support modules to declare ACL categories in 7.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backporting]Fix empty response for ACL CAT category subcommand for module defined categories (#1140)
The module commands which were added to acl categories were getting skipped when
ACL CAT categorycommand was executed.This PR fixes the bug.
Before:
After: