Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify ParseError to FromError for agent handler #2667

Merged
merged 7 commits into from
Oct 8, 2024

Merge branch 'main' into refactor/pkg/fix-agent-handler

9a2f6c9
Select commit
Loading
Failed to load commit list.
Merged

modify ParseError to FromError for agent handler #2667

Merge branch 'main' into refactor/pkg/fix-agent-handler
9a2f6c9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 8, 2024 in 0s

24.03% (+0.03%) compared to 04d0a73

View this Pull Request on Codecov

24.03% (+0.03%) compared to 04d0a73

Details

Codecov Report

Attention: Patch coverage is 1.00000% with 99 lines in your changes missing coverage. Please review.

Project coverage is 24.03%. Comparing base (04d0a73) to head (9a2f6c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/core/ngt/handler/grpc/linear_search.go 0.00% 30 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/search.go 0.00% 30 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/remove.go 0.00% 13 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/upsert.go 0.00% 9 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/object.go 0.00% 6 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/update.go 0.00% 6 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/insert.go 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2667      +/-   ##
==========================================
+ Coverage   23.99%   24.03%   +0.03%     
==========================================
  Files         539      539              
  Lines       47193    47117      -76     
==========================================
  Hits        11323    11323              
+ Misses      35101    35026      -75     
+ Partials      769      768       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.