-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
252: Setup translations with slang #255
base: 248-more-basic-setup
Are you sure you want to change the base?
Conversation
<key>CFBundleLocalizations</key> | ||
<array> | ||
<string>de</string> | ||
<string>en</string> | ||
</array> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only thing I added here. Otherwise, I just replaced tabs with spaces as the preview here was otherwise very weird.
"news": { | ||
"news": "Artikel" | ||
}, | ||
"campaign": { | ||
"campaign": "Wahlkampf" | ||
}, | ||
"profile": { | ||
"profiles": "Mitglieder" | ||
}, | ||
"twoFactorAuthentication": { | ||
"twoFactorAuthentication": "2FA" | ||
}, | ||
"tools": { | ||
"tools": "Tools" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably align with the folder/feature names in #249. I'll update those once we decided on the names.
{ | ||
"common": { | ||
"appName": "Green App" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only meant as an example obviously. I think I'd not keep the English translation file up to date (or even delete it for now), as a fallback still German will be used.
We can then at some point request translations from the BGS.
@@ -0,0 +1,4 @@ | |||
base_locale: de | |||
fallback_strategy: base_locale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBD. What language should be used if the device language is none of the supported language? German or English?
Short description
Setup translations with slang.
Proposed changes
slang
to latest version and addslang_flutter
app_de.json
andapp_en.json
translation files with example translationsSide effects
None.
Testing
Switch your device language between German and English and see different translations.
Resolved issues
Fixes: #252.