252: Setup translations with slang #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
NikoHadouken,
volkramweber and
Stift
as code owners
steffenkleinle
commented
Oct 24, 2024
Comment on lines
+31
to
+35
| <key>CFBundleLocalizations</key> | ||
| <array> | ||
| <string>de</string> | ||
| <string>en</string> | ||
| </array> |
There was a problem hiding this comment.
This is the only thing I added here. Otherwise, I just replaced tabs with spaces as the preview here was otherwise very weird.
steffenkleinle
commented
Oct 24, 2024
Comment on lines
+5
to
+19
| "news": { | ||
| "news": "Artikel" | ||
| }, | ||
| "campaign": { | ||
| "campaign": "Wahlkampf" | ||
| }, | ||
| "profile": { | ||
| "profiles": "Mitglieder" | ||
| }, | ||
| "twoFactorAuthentication": { | ||
| "twoFactorAuthentication": "2FA" | ||
| }, | ||
| "tools": { | ||
| "tools": "Tools" | ||
| } |
There was a problem hiding this comment.
These should probably align with the folder/feature names in #249. I'll update those once we decided on the names.
steffenkleinle
commented
Oct 24, 2024
Comment on lines
+1
to
+5
| { | ||
| "common": { | ||
| "appName": "Green App" | ||
| } | ||
| } |
There was a problem hiding this comment.
This is only meant as an example obviously. I think I'd not keep the English translation file up to date (or even delete it for now), as a fallback still German will be used.
We can then at some point request translations from the BGS.
steffenkleinle
commented
Oct 24, 2024
| @@ -0,0 +1,4 @@ | |||
| base_locale: de | |||
| fallback_strategy: base_locale | |||
There was a problem hiding this comment.
TBD. What language should be used if the device language is none of the supported language? German or English?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Setup translations with slang.
Proposed changes
slangto latest version and addslang_flutterapp_de.jsonandapp_en.jsontranslation files with example translationsSide effects
None.
Testing
Switch your device language between German and English and see different translations.
Resolved issues
Fixes: #252.