-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ember starter #19564
base: main
Are you sure you want to change the base?
feat: add ember starter #19564
Conversation
f6578c3
to
cb0f167
Compare
I tried to run it locally, and I got these errors:
The templates in create-vite are as minimal as possible because they dual as bug reproduction starters, and they are intended to be used to learn vite more than to create a production app. For Vue, you would use create-vue for that for example. We can't also maintain up to dates templates for all frameworks. So we would need to remove the testing infra for example. My take for ember is that it would be better for you and for us to avoid having these simplified templates in create-vite as they may end up harming new users more than helping. Instead, we could add the ember option and have an external launcher to your scaffolder CLI. Same as we do with Nuxt, React Router, SvelteKit, etc. |
Yeah, npm doesn't work at all with resolving prerelease versions as peers. :( Gotta use pnpm until the stable release
Gotcha, i must have missed this purpose in the docs or something
Ahh! Neat! I will explore this, thank you!! |
Done!
updated! |
Current Blockers for "Ready for Review":
All things on the ember side:
Description
This PR adds Ember (and Ember + TS) to the list of starter templates.
Some key differences from the other starter templates atm
import.meta.ENV.*
isn't a standard (maybe one day soon? 🤞 ) -- we don't want macros-code to change between packaging systems (webpack, vite, our old legacy thing, etc)Some key differences from a more normal ember-generated project
src
folder instead ofapp
folderTo generate a more normal ember project, folks should use this option:

old notes, no longer relevant
These notes are no longer relevant, because I've made the ember-vite templates as minimal as they currently can be, which more aligns with the other vite templates.
With the option to create a production-ready app by deferring to ember-ecosystem project generation, we can regain some of this:
Here is our official "v2 app" blueprint / template: https://github.com/embroider-build/app-blueprint
which is notably different from the minimal template PR'd here:
embroider-build/embroider#2301 (this is what this PR to vite is using)
If testing is desired to be removed, we can delete:
tests/
My Todos
PR Checklist