-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: local discovery #1811
feat: local discovery #1811
Conversation
size-limit report 📦
|
d604cb5
to
80780d3
Compare
863eb55
to
d7b36d5
Compare
Does this interface need to be updated as well? https://github.com/waku-org/js-waku/pull/1811/files#diff-7a99f40b2c8bda03c8c1333fd225faef1127292ec63c8af55aecfeeac1c1dc31L39-L46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, let's discuss
good spot, thanks! addressed |
1397a4d
to
ff31231
Compare
f3588f5
to
db29bb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
1d803bb
to
dd5768e
Compare
Problem
Whenever a js-waku node is started, it bootstraps itself into the network using a static multiaddr passed by the user, or by using default fleets. These nodes are then used to discovery more nodes using Peer Exchange.
Solution
This PR introduces the usage of Local Storage as a discovery layer that can be used to store & fetch peer information (
peerId
andmultiaddr
) of healthy peers that js-waku was previously able to connect to, for that particular app & user.This reduces the amount of time to discovery healthy nodes by storing previously known healthy nodes to be stored in the Local Storage which can be used as a way to bootstrap your way into the network without relying on the bootstrap fleets, thus also reducing load on them while increasing decentralization.
Notes
LocalStorageDiscovery
part ofdefaultBootstrap
option