refactor(weave): dedicated component for dataset versions #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=28a757bc476d2c278837f6b4436bf86d5d8d902e |
bcsherma
force-pushed
the
wf-react-bindings
branch
from
0effe9e to
0152b4f
Compare
bcsherma
force-pushed
the
dataset-component
branch
from
0364780 to
cdae1e8
Compare
tssweeney
approved these changes
Jan 7, 2025
bcsherma
force-pushed
the
wf-react-bindings
branch
from
0152b4f to
6f5953a
Compare
bcsherma
force-pushed
the
dataset-component
branch
from
cdae1e8 to
7a6bf49
Compare
bcsherma
force-pushed
the
wf-react-bindings
branch
from
6f5953a to
063e8c1
Compare
bcsherma
force-pushed
the
dataset-component
branch
2 times, most recently
from
9f66f49 to
e18fe0d
Compare
bcsherma
force-pushed
the
dataset-component
branch
from
e18fe0d to
14e2c6e
Compare
bcsherma
force-pushed
the
dataset-component
branch
from
14e2c6e to
99660eb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ObjectVersionPagechanges its display style significantly based on the type of object being displayed, with datasets being one special case. This PR refactors the component to render the dataset page in a separate component.The intent here is to decouple the displays for each type of object versions as we start to make each UI more specialized and feature rich. This PR is in the immediate service of implementing a dataset editor in the dataset version display. Decoupling this UI from the other object version UIs makes the implementation much cleaner.