-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weave): dataset editing UI #3341
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=d51391a47df76d3950228d33eb7d7b0d5eaad39f |
cdae1e8
to
7a6bf49
Compare
d966b60
to
0f15fb0
Compare
7a6bf49
to
9f66f49
Compare
0f15fb0
to
7338419
Compare
9f66f49
to
e18fe0d
Compare
7338419
to
994b5db
Compare
e18fe0d
to
14e2c6e
Compare
36c6fae
to
756fddb
Compare
14e2c6e
to
99660eb
Compare
756fddb
to
3ec0876
Compare
654fd73
to
e892715
Compare
922e64f
to
dd1b090
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small issue I ran into was when clicking on row ref links in the dataset viewer. In prod, the ref payload looks like:
"weave:///griffin_wb/prod-evals-nov/object/Dataset:aTIBCGcJAIEcCeyGFxV0IcKSgeYe1GllqxYitg40gBw/attr/rows/id/WmjDCz5lLX3e5MEbiheS04jqGK0XioX4D9L9HrTDb4M"
while on your branch it has an extra _10
(corresponding to the index) appended to it. The ref_read batch fails.
"weave:///griffin_wb/prod-evals-nov/object/Dataset:aTIBCGcJAIEcCeyGFxV0IcKSgeYe1GllqxYitg40gBw/attr/rows/id/WmjDCz5lLX3e5MEbiheS04jqGK0XioX4D9L9HrTDb4M_10"
weave-js/src/components/PagePanelComponents/Home/Browse3/datasets/CellRenderers.tsx
Show resolved
Hide resolved
weave-js/src/components/PagePanelComponents/Home/Browse3/datasets/CellRenderers.tsx
Outdated
Show resolved
Hide resolved
weave-js/src/components/PagePanelComponents/Home/Browse3/datasets/CellRenderers.tsx
Outdated
Show resolved
Hide resolved
weave-js/src/components/PagePanelComponents/Home/Browse3/datasets/DatasetVersionPage.tsx
Outdated
Show resolved
Hide resolved
weave-js/src/components/PagePanelComponents/Home/Browse3/datasets/DatasetVersionPage.tsx
Show resolved
Hide resolved
weave-js/src/components/PagePanelComponents/Home/Browse3/datasets/DatasetVersionPage.tsx
Outdated
Show resolved
Hide resolved
610d138
to
daa52d6
Compare
daa52d6
to
de7d336
Compare
de7d336
to
1ac6aae
Compare
Description
Introduces a UI for editing datasets. When viewing dataset objects in weave, an edit button is now shown in the top right corner of the dataset version page. Clicking this button takes the user into the dataset edit experience.
This editor allows:
At any in the editing process, as long as edits have been made, the user can click publish in the top right corner of the dataset version page to publish a new version with their changes or click the adjacent cancel button to abandon their changes.
Implementation Notes
DatasetEditContextProvider
is introduced around the dataset version page and exposes state and callbacks for the editor, including: edited cell values, added row values, removed rows.EditableDatasetView
is now always used to render dataset versions. It is almost identical to implementation inDataTableView.tsx
but allows for an edit mode where cells can be added, removed, and edited.DatasetVersionPage
is extended with state and components to manage the editor lifecycle (start editing, cancel, publish, confirm).