Move 'Excel formula' to s.json, rename to 'Spreadsheet Formula,' add coauthor, labels, releases
#9044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to `Spreadsheet formula`. Add `previous_names` Add coauthor @michaelblyons Add `labels`
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: Spreadsheet formula
Results help
Packages removed:
- Excel formula
Packages added:
- Spreadsheet formula
Processing package "Spreadsheet formula"
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Spreadsheet Formula (Basic).sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: LibreOffice Calc Formula.sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Google Sheets Query Language.sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Excel Formula.sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Google Sheets Formula.sublime-syntax
|
Yeah. We actually require an even higher version than 3092, since there's inheritance with |
There was a problem hiding this comment.
Automated testing result: WARNING
Repo link: Spreadsheet formula
Results help
Packages removed:
- Excel formula
Packages added:
- Spreadsheet formula
Processing package "Spreadsheet formula"
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Spreadsheet Formula (Basic).sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: LibreOffice Calc Formula.sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Google Sheets Query Language.sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Excel Formula.sublime-syntax
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Google Sheets Formula.sublime-syntax
packagecontrol-bot
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Automated testing result: SUCCESS
Repo link: Spreadsheet formula
Packages removed:
- Excel formula
Packages added:
- Spreadsheet formula
Processing package "Spreadsheet formula"
- All checks passed
|
@axemonk The main branch needs ST 4075, but you could create a second tag versioning series for ST 3092 - 4074, and tag the last pre-inheritance commit. |
|
@packagecontrol-bot please advise lol
I did a stupid. |
packagecontrol-bot
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Automated testing result: SUCCESS
Repo link: Spreadsheet formula
Packages removed:
- Excel formula
Packages added:
- Spreadsheet formula
Processing package "Spreadsheet formula"
- All checks passed
|
|
packagecontrol-bot
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Automated testing result: SUCCESS
Repo link: Spreadsheet Formula
Packages removed:
- Excel formula
Packages added:
- Spreadsheet Formula
Processing package "Spreadsheet Formula"
- All checks passed
michaelblyons
pushed a commit
to michaelblyons/SublimeSyntax-Excel
that referenced
this pull request
Jan 27, 2025
2 tasks
axemonk
changed the title
s.json, rename to Spreadsheet formula, add coauthor and labelss.json, rename to Spreadsheet Formula, add coauthor and labels
axemonk
changed the title
s.json, rename to Spreadsheet Formula, add coauthor and labelss.json, rename to 'Spreadsheet Formula,' add coauthor and labels
axemonk
changed the title
s.json, rename to 'Spreadsheet Formula,' add coauthor and labelss.json, rename to 'Spreadsheet Formula,' add coauthor, labels, releases
packagecontrol-bot
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Automated testing result: SUCCESS
Repo link: Spreadsheet Formula
Packages removed:
- Excel formula
Packages added:
- Spreadsheet Formula
Processing package "Spreadsheet Formula"
- All checks passed
michaelblyons
approved these changes
Feb 1, 2025
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a resubmission of #9029
FWIW, I just stumbled across this while going through the checklist: Link-to-highlight of potential issue
Does the above apply to github packages with multiple authors?
Excel formulatos.jsonSpreadsheet formula. Addprevious_nameslabels>=4075for use ofextends3092to4074for use of.sublime-syntaxThere are no packages like it in Package Control.