-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update typescript version to 5 #7272
base: 4.x
Are you sure you want to change the base?
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7272 +/- ##
==========================================
+ Coverage 94.44% 94.46% +0.02%
==========================================
Files 216 216
Lines 8463 8533 +70
Branches 2339 2339
==========================================
+ Hits 7993 8061 +68
- Misses 470 472 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 8c17262 | Previous: cc99825 | Ratio |
---|---|---|---|
processingTx |
22167 ops/sec (±6.72% ) |
21879 ops/sec (±7.68% ) |
0.99 |
processingContractDeploy |
38000 ops/sec (±8.48% ) |
38811 ops/sec (±6.95% ) |
1.02 |
processingContractMethodSend |
15290 ops/sec (±7.78% ) |
15153 ops/sec (±7.20% ) |
0.99 |
processingContractMethodCall |
26462 ops/sec (±6.94% ) |
27291 ops/sec (±6.06% ) |
1.03 |
abiEncode |
42440 ops/sec (±7.70% ) |
41796 ops/sec (±7.77% ) |
0.98 |
abiDecode |
29709 ops/sec (±7.88% ) |
28813 ops/sec (±7.30% ) |
0.97 |
sign |
1485 ops/sec (±3.42% ) |
1512 ops/sec (±0.76% ) |
1.02 |
verify |
359 ops/sec (±0.63% ) |
359 ops/sec (±0.56% ) |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
@@ -137,7 +137,7 @@ | |||
"typedoc-plugin-markdown": "^3.17.0", | |||
"typedoc-plugin-mdn-links": "^2.0.0", | |||
"typedoc-plugin-merge-modules": "^5.1.0", | |||
"typescript": "^4.7.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will any of breaking changes in TS will affect users:
https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are updating at devDependencies, there should be no issues with the braking changes except with our code that I needed to update at few places for the detected issues.
But for the users of our lib there should be, theoretically no issues at all. However, there could be some very edge case that I am not aware of. But according to my search and up to my knowledge, there should be no issues for the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
types created as output of build using TS in this PR are fully backward compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to my reading, the generated JavaScript is only affected by the targeted ECMA Script. And for the same ECMA Script, the transpiled code is compatible. I checked few of the generated JavaScript source code and things seems almost identical and 100% compatible.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.